From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29236 invoked by alias); 12 Feb 2016 18:49:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29124 invoked by uid 89); 12 Feb 2016 18:49:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:2363, sk:Debian-, sk:Debian, sk:debian X-HELO: usplmg20.ericsson.net Received: from usplmg20.ericsson.net (HELO usplmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 12 Feb 2016 18:49:30 +0000 Received: from EUSAAHC002.ericsson.se (Unknown_Domain [147.117.188.78]) by usplmg20.ericsson.net (Symantec Mail Security) with SMTP id DE.9A.12433.E952EB65; Fri, 12 Feb 2016 19:34:07 +0100 (CET) Received: from elxa4wqvvz1 (147.117.188.8) by smtps-am.internal.ericsson.com (147.117.188.78) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 12 Feb 2016 13:49:27 -0500 References: <56BB4004.1090708@redhat.com> <1455185675-27574-1-git-send-email-koriakin@0x04.net> <56BC85E8.6010409@redhat.com> <56BC97F1.3020108@0x04.net> <56BE26FC.8030400@0x04.net> User-agent: mu4e 0.9.17; emacs 24.4.1 From: Antoine Tremblay To: Marcin =?utf-8?Q?Ko=C5=9Bcielnicki?= CC: Antoine Tremblay , Pedro Alves , Subject: Re: [PATCH] gdb.trace: Add a testcase for tdesc in tfile. In-Reply-To: <56BE26FC.8030400@0x04.net> Date: Fri, 12 Feb 2016 18:49:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00427.txt.bz2 Marcin Kościelnicki writes: > On 12/02/16 19:31, Antoine Tremblay wrote: >> >> Marcin Kościelnicki writes: >> >>> On 11/02/16 14:00, Pedro Alves wrote: >>>> On 02/11/2016 10:14 AM, Marcin Kościelnicki wrote: >>>>> This tests whether $ymm15 can be correctly collected and printed from >>>>> tfile. It covers: >>>>> >>>>> - storing tdesc in tfile (without that, $ymm15 doesn't exist) >>>>> - ax_pseudo_register_collect for x86 (without that, $ymm15 cannot be >>>>> collected) >>>>> - register order in tfile_fetch_registers (without that, $ymm15h is >>>>> fetched from wrong position) >>>>> - off-by-one in tfile_fetch_registers (without that, $ymm15h is >>>>> incorrectly considered to be out of bounds) >>>>> - using proper tdesc in encoding tracepoint actions (without that, >>>>> internal error happens due to $ymm15h being >>>> >>>> OK once prereqs are in. >>>> >>>> Thanks, >>>> Pedro Alves >>>> >>> >>> Thanks, pushed. >> >> Hi, >> I've been trying to run this test on x86 but I get the following error >> while compiling tfile-avx.c : >> >> binutils-gdb/build-x86/gdb/testsuite/../../../gdb/testsuite/gdb.trace/tfile-avx.c:38:19: error: invalid register name for 'a' >> register __v8si a asm("ymm15") = { >> ^ >> >> I've also noticed the same error on the buildbot results see: >> http://gdb-build.sergiodj.net/builders/Debian-x86_64-m64/builds/2928/steps/test%20gdb/logs/stdio >> >> My cpu (Intel(R) Core(TM) i7-4600M ) supports avx, cat /proc/cpuinfo >> shows avx and a gdb print $ymm15 returns something... >> >> This is with gcc 4.8.4... >> >> Am I missing something? >> >> Regards, >> Antoine >> > > Ugh. It seems you need a newer gcc to recognize "ymm15" as a register > name - 4.8.2 seems to want it called "xmm15" - sort of incorrect, but > close enough. gcc 5.3 still accepts that, so perhaps we should change > it to xmm15 for the sake of older compilers, even if it harms readability? Would xmm15 still work on newer gccs ? If so I would guess it's a good idea to change it given that our own buildbot test machines seem to test with an older gcc...? Maybe adding a note of it in the test... or if there's a way to check for the gcc version ? I actually can't find the gcc doc where those names are defined at the moment would you have that handy by any chance? Regards, Antoine