From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 81481 invoked by alias); 29 Nov 2016 14:58:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 81455 invoked by uid 89); 29 Nov 2016 14:58:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 spammy=Hx-languages-length:981, H*r:ip*153.88.183.39, Hx-spam-relays-external:sk:EUR03-V, H*r:sk:EUR03-V X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 29 Nov 2016 14:58:00 +0000 Received: from ESESSHC007.ericsson.se (Unknown_Domain [153.88.183.39]) by (Symantec Mail Security) with SMTP id B2.80.32482.5779D385; Tue, 29 Nov 2016 15:57:57 +0100 (CET) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.39) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 29 Nov 2016 15:57:57 +0100 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=antoine.tremblay@ericsson.com; Received: from elxa4wqvvz1 (192.75.88.130) by AM5PR0701MB1874.eurprd07.prod.outlook.com (10.167.216.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.761.5; Tue, 29 Nov 2016 14:57:55 +0000 References: <1480428758-2481-1-git-send-email-yao.qi@linaro.org> User-agent: mu4e 0.9.17; emacs 24.5.50.1 From: Antoine Tremblay To: Yao Qi CC: Subject: Re: [PATCH 1/2] Add unit test to aarch64 prologue analyzer In-Reply-To: <1480428758-2481-1-git-send-email-yao.qi@linaro.org> Date: Tue, 29 Nov 2016 14:58:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-ClientProxiedBy: BN6PR20CA0010.namprd20.prod.outlook.com (10.173.158.148) To AM5PR0701MB1874.eurprd07.prod.outlook.com (10.167.216.23) X-MS-Office365-Filtering-Correlation-Id: 8d30ff9d-73cb-403c-61fc-08d418681a4f X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:AM5PR0701MB1874; X-Microsoft-Exchange-Diagnostics: 1;AM5PR0701MB1874;3:Kv7E8eI2CO9mJLJGENO3kb0m+hp8ZimRIN3m//HVx8OOXDKF0SuwSoQ3RDaroMEF3csGNuY8cZ5ArngWfCmlwPog7YflBj2SbmCVRXWRXDdL+53+WT0zrv7dP/knB1CPaeKmcZ4VzPir2WL/xr/3Nykggaq8nuJscCpgTW3uwZCN6VzGYL+o6MT/MxocqZ2SMLIffww9V3CySgQy7YnMHmhnKLm+i/1i7GcpgNx75v054GwFVeVKZy1dpgROyqXQowDoH4bAcAU7+9qJw/XNGA== X-Microsoft-Exchange-Diagnostics: 1;AM5PR0701MB1874;25:eLGIxYAzn/w+eiInVieknMaT0LcC5JwMywB1RF1AAHWXMMvsXAOcHDX4omIbr+bAgS9VEXSYhFNlbEtYpbX9l8WzJxCFm9IYaXqA0BRNci2qdPnc3PsNnTeWPYmkWF5BR+2pN2md2wAEYc7YQADzsgZGsVMIcGafNuDL1DUuVOsFp+KGGFydeFmY38Ot+/T7afWaSb6v/L9478YSzgtmaRQFAWV/O2P7K6f3SVAe0H4IN+y7quJsh+z7JSKr4Sd8J0syXabxD16O3AqJYc2vAKVh2/SJC6h4WKqmLMJriKdUlPjRTvEt0cxXycanAoT2lCZBRLYvgMjuhr20OQRjQR54D54rlrzHZsMd7yhPlMErCTm7UQrxQ0spXZq8CMexWLlQYRu2p0bIyRDYT3O//cu/y7iIc8DKzHHhx1jfxaHqjXcy39mXbMC7+6v/jB/aAE28JjYo304uAcdScu6DVhQskzOUSf5XG9miDTRz/T4QeoG1CZsHFmBThn8hdc8Q3/pK2AJEcBg9Fc3NkRbT/tzNxF4d+mOK7NhrSf0gmOeXPFNhBBEtkEASBZIWrQ0s+cfZO7QaRM/Jjf0UWLdawLCzhCVG0iIMhZDmVl7IxkcbpNtC8pJgdraYdlnj6RE5kEFj/Sc8iqR/OQXT8Ub+z7N1ZU2izGdnwsHsTIVq+9WfWG5ZbkOJcT76tUvDVQwbc0nX9u5W45KTOKIeF6asKi1AT3DBP47n+7t5wnFj4W9xYh1mjWps80K/tdCP6Z52Z812ANqtxyxKAzV36VbXRA== X-Microsoft-Exchange-Diagnostics: 1;AM5PR0701MB1874;31:jfBoAkttSDQWshzS4cX35wb22gl9pdNWcpu1cr7QkdHBhR21D6F8ulY/N6cMvM8vViXkOVy709dVIeDQh50DTXoDViXZT4NxxwLLR9emAyhGDHlUwNaIO/jlkaNDPvSighbc/INC5DPeukWUl2jcUagAkkeJL2/Mo6VZXGqFs/2hIBFTB9Qnul631LyGvycsMwud/d1b7ZWdZ5IL4q5BnBr2xu4geIaj/01C8Lm1LjyxIoOL+5yHx9wpXDSWjLcAdXxg9szNMN1Qb+8AKyXArw==;20:re+T4K2uBEQj2Pj7M3F+n2vYSUIrHNN7O6piRG0CdU/KbioDrVuYn03gc7aY/V3IVNGiBPhMUv4tPJF/LBoqvPXoKkyN2p0VsuVX7K3knzxbtG/8qL8/qKNODb/TAmO/lpVAm/EG3JyphwB26PmCJloNxLVnjFNQmD9jUurTk6+UmNHJQVYJLIjJZVnNOVZs4Q2Ab0irVrqfqNzCG3LGimg1LSBjd0XOSQ2WM/L/td8CCNT/b/mpFXh3hWC0NsngT6mx0llGFHYql+rzQ5Qd7GCVwcwkcdsXaoOXKNG3R87yS/iILrWCvCFXHX17hMldz2pgGEPFUeNBI2f24gIbIxBLYR1Z5eOSoMbQNXUKiayiLFVRSS4BMJ4bsPNaaZjZMMYY2DxS7CAIE4HK7Ut2dZPFeWcG8SyjynJCHRFrf77urk6I6Afv7hYTvm7w/p9WDIOyVLJ9sdSszGt1PoEDtcBtyUgW7TZnhDV/oYIpaCMpNVGSE/6x7V4oRO5HvSAX X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6060326)(6040361)(6045199)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6041248)(6061324)(20161123564025)(20161123562025)(20161123560025)(20161123555025);SRVR:AM5PR0701MB1874;BCL:0;PCL:0;RULEID:;SRVR:AM5PR0701MB1874; X-Microsoft-Exchange-Diagnostics: 1;AM5PR0701MB1874;4:3gHGtzVjjdjzbKUA/mi0MEeA8eMCTj+E0ngJWY/pcJooykjQMdz0/UMYYHNAoM/YWQwiQAmCZf+98cjXurh5S0weLms5SpKuWyu4PsGozm7ZDimy2d/V2tMC/Xhx/BbRRwTL/Q9+WPmuNEYIolq64vmSmA5K/2iBpHp3rv/YaZM5sZHf3B/QJKErvefHLIMAX/A0jNG0xNhzEQZEyTjpHYY9L93S79T0x53xIJEVFlntSyBFCTFnm1iKCPSCZydP5PH0RVhHU180ald9N+RjkbphMzADLbbSWc+QxijN1Td88OifF9e8QBCmsXTcoz8n2BguBNyOMCC4ohoxglzTxAkI2tc65UUpPx5/9OpL6R6CdwdHD0HxNRDHa9+VO2zX1WY0XztqYR3F+1+AFYmvEznLLbGlSPVWDt9VH8/2LploBJs3iUPtSQL+IN8I9KpenLgFsEGnIBp+AEwn4yQNcj+QwuZetTFrMzZcqOSlxdsaYFgKmmS5qvx6ZKUCrPqS3EMw6iV9tibm8kEHULQgsWDlVvT2BLo1IIYvry7kgwq42TOOSnFZwjwQGFq4QA05AnG7vZFJ8dya4AVhPCDkwrAZ5n9Itj5Za+y/hCUJ+Aw= X-Forefront-PRVS: 01415BB535 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(199003)(54094003)(189002)(81156014)(81166006)(48376002)(4001350100001)(97736004)(101416001)(36756003)(5003940100001)(8676002)(7736002)(3846002)(33646002)(6116002)(6916009)(4326007)(733004)(39380400001)(6486002)(68736007)(2950100002)(229853002)(39450400002)(6496003)(39400400001)(305945005)(39060400001)(38730400001)(6666003)(110136003)(39410400001)(7846002)(2906002)(50466002)(106356001)(92566002)(54356999)(1411001)(66066001)(83506001)(47776003)(50986999)(86362001)(76176999)(105586002)(5660300001)(189998001)(42186005)(4226002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM5PR0701MB1874;H:elxa4wqvvz1;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;AM5PR0701MB1874;23:GsRog+NdGnePIhDbH9/AR5mOCZGjF+wKWVrtjGk?= =?us-ascii?Q?79HVwdvD8QVCNp5PqnzI3boUbamwLdhr2wp847UYSj8tA3b007HEutxCtTsD?= =?us-ascii?Q?G6yteYnHnxcRX+kayMpa630GF2XsRYAIMIbg9JAwxoQahRCvrrj7Te8KVhYs?= =?us-ascii?Q?aBNrn9pdHRCZCsdQj8jGaWQT3BkSFKWPCTTKQCHuRyA3bj8RTkjWpiBTaWe/?= =?us-ascii?Q?FZH/M2PP7QbceQWxA189TQjlkWdk92HZWUZyVn7MHja73krtH/C2RGstnTSd?= =?us-ascii?Q?BjQgj2kBNtswbrbRMDB9LQA/Zz/xmKpzi0EnZ7lfJkeKxSuPEhZVa2MuT/0M?= =?us-ascii?Q?BgRusYMz1od4qW12fq9W1PLWqXy8rTIeCbHpfty8LY3vNtX/4O5F2ZEPdk//?= =?us-ascii?Q?Xw7JDMAtw9M2R4O38vGkYCNDXdfeNOhSKb4D1RJLGKddtrNUfF4RNNsg1u19?= =?us-ascii?Q?q6FllkYH3kKBBmCGzKwztsm2SvBvPdE06ewXfZnt1uhnvYHLEC0bKZ5nSsT5?= =?us-ascii?Q?oBk8xgp01AzVXGaJmxXmat2+mqA80Asdiv3zX/U5DQ33jKgnkG6anXnUBkKN?= =?us-ascii?Q?zrNRV6Dbp/yGW+rEQHv0EI+4EQiO7Hv3wdb334+ltLsa25ZBTeNDz5w81Y3q?= =?us-ascii?Q?SweH96wznBwNzZdn81Og8pqsceJ32tr1QacTHzUGteIOJqMGhSDdUPAjMb+o?= =?us-ascii?Q?aziq9fsor8nmfm0+lVdNgzu9iqgDXIPZrCZoOoHbeVvWBIpu6HTdSfwc3lQp?= =?us-ascii?Q?s0Jtne1iPn+A75REBBOnzBdqyfXWrwmpkgYnV8VoGEUfePmotTNzj1fYHzKS?= =?us-ascii?Q?wc1Rl5JGvckg5NwpagzLEPhzFcsdcB7CnNhlNCilfA+JT1Z5UIFVC/d8Hobi?= =?us-ascii?Q?GqJOrMJxZ81UAlUVxUY2Fl2cUKewcIi3P2EEf6bZYZ2V46b21yBU3ULMIAEe?= =?us-ascii?Q?H6qnkdaRK8S/WD/mwhlTWZm0ovD1Ajw6gmM8qB6LY4vC2pN+2JSzxn9L+gNx?= =?us-ascii?Q?K0jCIGdPxMm4BLcTsKsDDhV044S3wqwEMC0vzAKnrqDRip0BZ4CFAOJTwIb1?= =?us-ascii?Q?UqBSQZxTN6TJY7U5qqv4O45yGZ1Wlne/YxZppK2nWRSKJ9TwXKuxsx8ImvH+?= =?us-ascii?Q?20QndhLVMQgoZTpZak4BH6qkUQ+JwfkBFKiU4TeTkf7a998cuGgGI39mM8wC?= =?us-ascii?Q?1Z+kr6LOPC2RiNwLIixcmSeV7nW1k0NRNVGq3n4Vuxi3jCjbzrwkaHeeZfoj?= =?us-ascii?Q?7GFFg4Rgkt1kIiwRqewUsu4aT1cDxUmWflzgaMS2Dapv1/SHxnN0jBWJ4+IE?= =?us-ascii?Q?jtNnuCWnY/ll++k6iWrQA+sU=3D?= X-Microsoft-Exchange-Diagnostics: 1;AM5PR0701MB1874;6:r5xdMUC6edPf33oc3f7sAWymQ23GTi4FBMi6OeMPd8MjoMlSpcyH7PAB6OSLdZnNxjWxChTJILRXFPjXc305KPUMhnpzw0PvnSBEswKme8HHoVfE9cP6GZ14aGyKoI1xRb4z3FfnPSy1bdhKUVBSwA9NJKkLYOdWmFetM7Wt0ptWhqQOeHM/4pHv2yQ9eBHaZEVvUfOFW09FnGQD/N2fVBMLYQu9lMbCsjYOBzz9BLOdxA/JEeDDiJO2+NcuRwud0ytCE4DP0xxaHjZb3HL2DomrqB05vHzxzowzsO0aOc6Zl/LBtcDdZ5R1/csG5eg6+BsG1pjBb4nAVx0TfNXZUNTB4KPwjx2gQe0HNgIK5kk5slbOio0owrFFIfzX6u8rjGXIPPT8NAk3tKmZh5XJByNlBsReOZiBthV5hwZqbXIqx9vtVtrYEmtWQK6SzvGEDvyl/s05KilX74NSLhU+Zg==;5:CC2qReBoTehmACs+4xTEz2CKy7wcR0A1O5DoIfskrp3Idjt6P+t777ctnWxETLwFhAhy8UOmGyk3VeDhqqy+7yivqqLmz7FdE2vR0FaEhi/0uPfXC6QqIE7FMXpCC9iM6fWv6HJ0zC285NUz/wMjF7syEz+iKUtqylNu65AbEVM=;24:454vPEZz26JSeDF0BnOAMaaD3dfn/r5sRZjcHFNUOPB98iuZKs0vd1UZGybwnuRc+A1pIY20/rNFBCt6OxUsutor3ZH0rMD4k5g4VbrYp30= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;AM5PR0701MB1874;7:eAWMahHWiH2pLPdFBCEZbiifs9HTrk2RU52sYsb51borqMu6xXmmDFdrjx91GNaaHbxaXXzFIVbWoPMWgSl3mwmpys8pfHa6Pp9S06RdARKnXkL8QIM9y5etXtZzt/H2j8YpI8LGVtQQvMzBVAQ0n52fZddFR3bEW2g7LvPoSn/sORjPHL4X3eh28r4NPxABBEZkQqsYVenxZtqvmyVt2ulUtoTgnyEQCHlPewYghurMCyKSKnpsohblhX1hKvgE9p2EMLH4Pqv/i6hV6vDXELoCtQ1JUQLn2ma0smF5h9zaDsqqo0I7wPqmDJp1qvPgM22Omp1WHjGHZTc1cCnGCvbKbnEGLx3yfoOHjVn2+jXMRT3AmzV/rXCHfZS+lp2FTkFoUWjB8rUnfSLxRICnZ/4F8N+c+AEJRNPIV1sUNzltJhSpfbdWwEfydLOYC6MI4KNMZpfFFE47uyjki53hFg== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2016 14:57:55.6392 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0701MB1874 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00945.txt.bz2 Yao Qi writes: > @@ -436,6 +461,89 @@ aarch64_analyze_prologue (struct gdbarch *gdbarch, > return start; > } > > +static CORE_ADDR > +aarch64_analyze_prologue (struct gdbarch *gdbarch, > + CORE_ADDR start, CORE_ADDR limit, > + struct aarch64_prologue_cache *cache) > +{ > + instruction_reader reader { }; > + Could we use the default constructor here? If it's kept. > + return aarch64_analyze_prologue (gdbarch, start, limit, cache, > + reader); > +} > + > +#if GDB_SELF_TEST > + > +namespace selftests { > + > + /* Instruction reader from manually cooked instruction sequences. */ > + class instruction_reader_test : public abstract_instruction_reader > + { > + public: > + instruction_reader_test() = default ; Very nit, but there's a space before ';' Also I wonder if we need to specify the default constructor explicitly ? Is there a rationale for it? It's never used too, unless you apply my previous comment.