From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70333 invoked by alias); 24 May 2016 15:08:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 70323 invoked by uid 89); 24 May 2016 15:08:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=H*RU:Unknown_Domain, Hx-spam-relays-external:Unknown_Domain, H*r:0400, HX-Envelope-From:sk:antoine X-HELO: usplmg21.ericsson.net Received: from usplmg21.ericsson.net (HELO usplmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 24 May 2016 15:08:38 +0000 Received: from EUSAAHC001.ericsson.se (Unknown_Domain [147.117.188.75]) by usplmg21.ericsson.net (Symantec Mail Security) with SMTP id F9.C0.03614.F3E64475; Tue, 24 May 2016 17:07:44 +0200 (CEST) Received: from elxa4wqvvz1 (147.117.188.8) by smtps-am.internal.ericsson.com (147.117.188.75) with Microsoft SMTP Server (TLS) id 14.3.294.0; Tue, 24 May 2016 11:08:35 -0400 References: <1463757161-25850-1-git-send-email-yao.qi@linaro.org> User-agent: mu4e 0.9.17; emacs 24.4.1 From: Antoine Tremblay To: Yao Qi CC: Subject: Re: [PATCH 0/8] Use reinsert breakpoint for vCont;s In-Reply-To: <1463757161-25850-1-git-send-email-yao.qi@linaro.org> Date: Tue, 24 May 2016 15:08:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2016-05/txt/msg00424.txt.bz2 Yao Qi writes: > Nowadays, reinsert breakpoint is used in GDBserver to step over a > breakpoint. I want to use it to handle vCont;s too. The idea is that > when GDBserver receives resume_step request from GDB, use the software > single step logic, insert reinsert_breakpoint on the next pcs, and > resume the thread. This means we have multiple reinsert_breakpoints > for different threads for either step-over or vCont;s. Patch #6 makes > reinsert breakpoints thread specific, patch #7 does the major thing, > and patch #8 claims supporting vCont;s with software single step. > > Patch #1 and #2 fixes the existing bugs. Patch #3, #4, and #5 refactor > the code. > > The whole series are tested on arm-linux, aarch64-linux and > x86_64-linux. > > *** BLURB HERE *** > > Yao Qi (8): > Switch to current thread before finish_step_over > Delete reinsert breakpoints from forked child > Pass breakpoint type in set_breakpoint_at > Create sub classes of 'struct breakpoint' > Refactor clone_all_breakpoints > Make reinsert_breakpoint thread specific > Use reinsert_breakpoint for vCont;s > [GDBserver] Support vCont s and S actions with software single step > > gdb/gdbserver/linux-low.c | 180 ++++++++++++++++++++++++++-- > gdb/gdbserver/mem-break.c | 293 +++++++++++++++++++++++++++++++++------------- > gdb/gdbserver/mem-break.h | 35 +++--- > gdb/gdbserver/server.c | 17 +-- > 4 files changed, 412 insertions(+), 113 deletions(-) Series LGTM. Thanks for working on this! Antoine