From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122869 invoked by alias); 26 Jan 2017 15:27:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 122840 invoked by uid 89); 26 Jan 2017 15:27:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=H*RU:193.180.251.48, H*i:sk:379390e, Hx-spam-relays-external:193.180.251.48, H*f:sk:379390e X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 26 Jan 2017 15:27:18 +0000 Received: from ESESSHC002.ericsson.se (Unknown_Domain [153.88.183.24]) by (Symantec Mail Security) with SMTP id 83.3A.28805.2551A885; Thu, 26 Jan 2017 16:27:16 +0100 (CET) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.24) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 26 Jan 2017 16:27:14 +0100 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=antoine.tremblay@ericsson.com; Received: from elxa4wqvvz1 (192.75.88.130) by AM5PR0701MB1876.eurprd07.prod.outlook.com (10.167.216.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.888.5; Thu, 26 Jan 2017 15:27:12 +0000 References: <1485436646-12223-1-git-send-email-antoine.tremblay@ericsson.com> <3c0fb039-513d-9c8a-5851-e13a32d3d3ea@redhat.com> <3ac9874b-d4c9-8cb2-c4ab-81d20d41689d@redhat.com> <6c8d340f-156d-f619-bf81-1c1780759a17@redhat.com> <379390ed-98c6-fb7b-b217-b768e435bf5e@redhat.com> User-agent: mu4e 0.9.19; emacs 25.1.1 From: Antoine Tremblay To: Pedro Alves CC: Antoine Tremblay , Subject: Re: [PATCH] Fix crash when loading a core with unexpected register section size In-Reply-To: <379390ed-98c6-fb7b-b217-b768e435bf5e@redhat.com> Date: Thu, 26 Jan 2017 15:27:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-ClientProxiedBy: CY1PR20CA0074.namprd20.prod.outlook.com (10.163.250.42) To AM5PR0701MB1876.eurprd07.prod.outlook.com (10.167.216.25) X-MS-Office365-Filtering-Correlation-Id: 2f53d1db-6666-4b21-49b6-08d445ffcda7 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:AM5PR0701MB1876; X-Microsoft-Exchange-Diagnostics: 1;AM5PR0701MB1876;3:6MBn73SM+OioY1yN9LX5Ty3I10fvX7jCbpr/m178A1c/Ht0J1/pClNAq7ymyMVJ0inWTw/vEQfnJXzFJwuXWPox0dD0yaU4Tck0IHaed0GHktJMtomqWj/N5ZLLZ05Gul94M8mk2siGddaOe1Cdpd1kK3u/DmC78l7j3rjI/KCm0olrG6jgX6vF27i/Emaq1hX5rsi8+xGcLGrL8RyMdWEHBjB2S9E5YPDmoBF0KgN1JxPfT9VqkfONc/4QQdggxKqDIzf0g98T2IY3ZbLj/GQ== X-Microsoft-Exchange-Diagnostics: 1;AM5PR0701MB1876;25:wgcGkE2raWFNe6A/bTEwzPT6NpWxfEIgkyOgRC2P4sWfRlaC53I/kEiHMcynZpt4NcMTFyAEnXHle5MOcbz/I+u76RhRVkRr7PASXX4CPaEKcxOwInP9lQp2Cs/ETMZ8hstRBdotzNc9Dur9JPq6GLPA1rKKCcALTqPOfwIqN8WPmEOp1aBMvR0jd/CtMG+fhuQldiBgAX//8MLor3t4CLsy1Cn8skY4ZRV8a5GJ2AV4suHZkDkM8t7gYzGCPQOKLOOW8RHZj8iDQrp1j+3SAMkDo/eqrDrAm4CwhPEnDU//V10qfqEGPDpKpE90lwdm7u2BaJgtcTJi9yyZrDhVH3IrEfg2P/71eelOYPKqLzb4+qpKMsGpllmmpZ9nSdyC+QudPPuajxUXLRiK6jzHyCRzGG5feDKvdW9pNg2P4gbsJ9+uuHCUgBwHzjUinVUtCEhVNnN5y0RcWj7mfmdMQ9ZPu9wQuR0Y8OmaxekMho8EfOyglw2PemnjVz4fD8NZRh/kbt0TyK1o2Ym+pJL3Dq4bEgxmW/HRRVCwdjDO49yXpQ7kNZ+l53lhNhiGbPXDoAraQqIDjJe+SKtC1MGOP2mHUNQApjIjWVmKnv7qwwnLeSBRNzKu1/5sgg/pYuPnZUwsmnoPNB5O+V7zBKhyJBbFzjTUvFmFQvngQYxTd/5PbR7xuj9klDnaa4CTmcLhZnPLSuU5VSifjFeOmoIhiA== X-Microsoft-Exchange-Diagnostics: 1;AM5PR0701MB1876;31:I9T45DF6ari3zEtzqIIvnj6kDEjcrYd9i2OXEo2nfUtR7v4J7Q5ND4tUpE4V1JT0sjpuNL3jE/7UEEHFerapVMSQZn32r2n2tlW6grSdlVaXw2zV9uxR9CHuap3kZys1dvvhcViuBRub5Z6RO4pGwsbeMJtTUUof1lAYQbOOG3t5/EzXbMyVA7/IXESRN40M1PYQFx4LlaiwZyRf0bWqeT0ZhE7HoeJlAMKfTeMSCdBS4QUeQpVSpXirOEsQi3hQ;20:mOr+R49au5XRE2HA/aKyy4laBFSS3cJ9GkNfv63XXjICSaqTutaVenJWlah7dDA+RtIVgg/9AjNnuDSeZMChFsfflSQK4Z0ONGTzR/hHmgUSJQn9VpZj6ENG7Mg4Eqsl85TQaDynuWoKx1ZMnorewCfPlKvvxogVO7ovMYtWPUozbZEQ3t8SIjIjn9Y7OyjV4IhnE7tYWIeLZxZqa7AJcm7GMJuzcd8ZoKFg/Rqprvx6Y/bVlszHNov6rME91jzprayWJC4klC8yDESUtLeadVNI1cNRmbknYS/a9QjztDGfj6lI834qRsHSZKG6O3Gzj5NDr+iEZsyWiQK/SoPlW5YY+i5yiqN2cNOuOKQoCqeMcCbV/K/HeWJTsXfj2uGVN8hGpzqlRKyU9hfQUUAoiv4cPEJbOuAAZerS/CcMHgmufk8M/qGDqbJeHxNe+1SZwZOR9YAjItiMbhdtLhja2z+D+fmuxTpkNDvTUX7lDJFTBRokLTNtbZMaUwNzlsxT X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041248)(20161123564025)(20161123555025)(20161123560025)(20161123562025)(6072148);SRVR:AM5PR0701MB1876;BCL:0;PCL:0;RULEID:;SRVR:AM5PR0701MB1876; X-Microsoft-Exchange-Diagnostics: 1;AM5PR0701MB1876;4:ZuvasUuMfDaVk+XzLgAXq6FJlUSCQRkm4YWeT6ZQXh9wlWoEAuX+MmQRBpDmzOTlCSKsJyRdbBZl7x6Jn5E8E0cW06SXRVnBfw5WDFLdy0Fccz9MmFhWlaQnFjDX30g7b/R+nc1REE4J+s7GZ7Fwrh0S6bYocmWsEvvCyiwKJujkMHJPLWH4ooPKxPZhv9q3fhG0+CvHdvzrIBD+AI6opHwgSBWlCa4KllCf4mEp2HPwhe+Z8wIAKv5JlpgU5naLKu01YbCg+BBQICGLH71B+5hXBKB2miVHrdA9Peebpdowi1ZEEURqMm+IX0UNskaRUQrpiw7G0Y41ckXb/fVzSgJYkxOu8FhRGyeY6xiY6JWhi+IGRjlJqBOajYAiC/inor6fN+7Kauu3lzXjaqgf5okRs4pX94xAeHrV0nUNim+RIiNVuPCrl9FXVOpqTFvzizorpuD1SHo07t+JSJguwnimiByc6+4J/DNuLltK2fUUOseNhgf7OAIfceO6Ppt7xYr8V1gaZxR8Yc2xIjvi2MRsZiYKy1RwP9Y//17PFuP/FBU72tCTlK/v6JegDWnrBsLzS8XI6OMd2BeFm3jAYg== X-Forefront-PRVS: 019919A9E4 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(39450400003)(24454002)(199003)(189002)(52314003)(377454003)(53936002)(6916009)(2950100002)(229853002)(6666003)(6116002)(38730400001)(47776003)(6486002)(4001350100001)(110136003)(97736004)(83506001)(93886004)(68736007)(5003940100001)(6496003)(5660300001)(86362001)(3846002)(54906002)(106356001)(81166006)(54356999)(76176999)(50986999)(50466002)(33646002)(4326007)(36756003)(305945005)(7736002)(189998001)(92566002)(66066001)(101416001)(42186005)(2906002)(48376002)(25786008)(81156014)(8676002)(105586002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM5PR0701MB1876;H:elxa4wqvvz1;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;AM5PR0701MB1876;23:xt5mk92GHHPOReRvudkt0koAE4Oiy7FO3Gz24dq?= =?us-ascii?Q?OyRgiPDkenm7Z6vb8b/WcRuvMksGMxvaT641aRNmNAazs17OI1PRoTBpOlH2?= =?us-ascii?Q?+Q3z3yZy3sToiED4nRVqkbNKoCOijxKOvM2pv5yudZmDGFX7wGfYpO96TbqZ?= =?us-ascii?Q?b4ryRj1P0PDZ5bVd9nRTrodds9TfPAq7P/2WfAFYoI4pCFVGEm+lvhXBGyLw?= =?us-ascii?Q?H/UafOgk1Su5RWUouLKpptAeV0vIlkOlM4C9q/3OljqNT7mmGIjhPvy9nXMt?= =?us-ascii?Q?qXhMp34AVGH2MmOhwHEna/wZaJSFxdg7eWykqOLZGyOIX27JFcg6lZN1Alft?= =?us-ascii?Q?qfiqQWY9PgiQ+rQmuhUmwM3NqQCSBqtKTm3/6X3AvWshLaiH0LF0uJp6Ehor?= =?us-ascii?Q?lz8tgL+fIIcPt91wdDFAeH2IwdboUdV+Qo42FBderQYntWORy5ckwBjU0ONd?= =?us-ascii?Q?48hOAUzcCwH8OGepRfzvMCzUMBrsIUZKBS9w5WT83Wh3H/1afsP9Oy2LJQCf?= =?us-ascii?Q?yvFluYLFyYz2/fUQo0M8xemPcVMKqRtJ8OpKYvxAA6gMWviC6IiWNc9jnyIv?= =?us-ascii?Q?mur74TRvBX9JniW3TRyjtJ+9azC6AKeskpusCP65ykSDbvTjXZy5C6ng6lTH?= =?us-ascii?Q?SgpPfE70CEBloYgj/Te9W65CZM5UkV1gV8wgTo7fJnqkobkLYPmeegk9lyt7?= =?us-ascii?Q?5WQFCQkKlx5F6afUCisARn9ewDyL3nmq6tz0gEF8jupIbZH5b8JGnj3uUQ/e?= =?us-ascii?Q?LK4rWJjojKz/3sriwdh+154wPb/G3j1r0qbJFVEnzffinOctAA7HgwzLQM4x?= =?us-ascii?Q?HQ5zhEQBM9IOXx+DFfpgJxgm7WP/KEvMzDkDLBSJPauWjUHVuMmD7BvJXW2Q?= =?us-ascii?Q?CHrJmLxLLg+NM5oV/5JBVKQIf3aC/JODeOulD3cWJO8BdI5zc6i5h8vGOVFE?= =?us-ascii?Q?1267SS45B1XjgMb1OcGWnDBZajrprwpgfcxKLd6eYheDUH/4XroKxSfwwFrT?= =?us-ascii?Q?skunUNRZ5SM+gzOfRo3VTeaZsjM4c+61CrQAbKCcW3gweUJIolKJhzjymdFo?= =?us-ascii?Q?uBL026MhvtkDkUO9Be7UWi05ak8k5xrv9QJJiw6fHFG0JAMHYJQnVRkPDZwF?= =?us-ascii?Q?G4U2KjhD1pnZfvqE/yaVAiPQN1N/HDw+1TECv/kpuSPGAc8i9ezuq1zjsS+q?= =?us-ascii?Q?yKnIE31GGSRzeezJdkNOkhZDU9BGYnub5QyW40sBpL3jBJIMsGX/LrEINnJ/?= =?us-ascii?Q?fbtAJiWnDm++GtvanFqYcrJZdtBF1tQ2B12sso0jN?= X-Microsoft-Exchange-Diagnostics: 1;AM5PR0701MB1876;6:4iS3dSBThEf1XgawbKr2gwfFmO0HFFp5EgUnZHohe5F2NRs30fEZXiPvfuaNo3wxsbWuWBFUnn5gNKLA2c8T8ACqjFnGN8ifLEAXHZ6GEmXPwYXZQ79tKDyGDH+l1LmcjcGSJ4lMPTrU9a+YR1NzcR71ezcZdOOMS15xD7Tr9Gyibeqh/TeLhlMdl3v6SYz37S5P9EbZeJdP5PoYEJMd5K7GrPCOCFocP4Yji80m1dhCmLaFzORRP0P/E+Isd7PtOGx1cJdZAfFpegG/wwgXl8OEdLXwev2M4Xh6r6uRYGJS5hFQIn/p8fz2nOExR0eMKtjog+S3UEzAgYchkFYf/b1I97CNLUk9jXEmdM1yKh6cM+4S4K6SE/DEsjOe4jo8GXDAPrNIvUdgKDyPM13NRCdD49D72xJ8mgO9fF1sXY8=;5:W8EC0QFfC2kc5B/9s+uB9deH/ZLbYqGCXwwHedun9FamS13j73Z0E6Y0R0u1CF3fQrbNY8/wWt1/dytvDmCasrGvpoRWa6Q1E5x4kSIrduj8py79lc4UGVv33j3em+YiIFWRMgsuiUooggjwXYBn6g==;24:EL9Vr2htq16CpCVxqnu5gUV2NErSirCwbPhtDGv9mHl3ud8yXa9e0l8CgD+DwnGg4+P3ELNuVZLfbRdzjTC+Uq7iEnQxkVACSHiRGCvwopY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;AM5PR0701MB1876;7:hATWXpnaJ2XlpYF0De9ggDILVx1ZgtMoAIA8ZaLJCtZKOLpjThxjtWSZ0wTFGbqOHIRYlvIGUrSxBlZC/hGQGbRqRL8EmBhDlD7UIhE57NDsE+1T8BzeGH0BF9LswpD1lopqVb2S31iw7kmY5dygURfwWdkFirGn9fdVaZap6/ngH/sw7fbksI86xml8qmavjucg3yNSoCZ83y4FdyJoG/ARazcSsDqYbgOljq97SjZ/YRBx69XYBa9C+AFHMP1tnBycSre+WhM+33T/rrI/FI4NIDhQxzcmOpxgnvCrGzMzKqZrRKktc9xZIAAp7uiGPT0EXmIbqG5dcGKl/Sr+puaXXdjQrS4T2gWugFxjlHt/FX2jpZ7rVhNJlSUObwi0TNxATKfQRZwfqVXIjBKBnjn+U0+rgFf6Yr1v/oR+eyEm0XAl4GNM2+Yw7sY2etBw2R/SiVc0ZQrLIvN0IGYSGg== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2017 15:27:12.5824 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0701MB1876 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-01/txt/msg00582.txt.bz2 Pedro Alves writes: > On 01/26/2017 02:59 PM, Antoine Tremblay wrote: >> > >>>> Ho yes, see v2, I added "For example arch-arm." Like you suggested. >>> >>> Eh, "arch-" in "arch-foo" was just meant to show I was talking >>> about an arch. I didn't mean for you to keep the "arch-" part. :-) >> >> hehe I figured but wasn't sure. I'll just say arm. > > The right name is uppercase "ARM". ;-) > Right right :) >>> So basically, we could have a testcase that dumps a file, and then >>> loads with back with no executable loaded? Do we really not >>> have such a testcase yet? >>> >> >> Not exactly if it was that simple it would have been catched by >> gdb.base/corefile.exp >> >> The problem is that this triggers only if the core file register section >> is larger than expected. And if you just create a core and read it the >> register section is ok. >> >> However crafting a core with this problem is non-trivial at least to my >> current knowledge. > > This is all information that would have been very handy to have > in the submission upfront. Please put it in the commit log. > OK with that change. OK > > One piece of info missing is why didn't GDB figure out this is > a Linux core anyway, assuming it's a Linux core dump. > > I think the answer is that there's no ".note.ABI-tag"/NT_GNU_ABI_TAG > section/note in core dumps. I think we could teach > generic_elf_osabi_sniff_abi_tag_sections about detecting > presence of ".note.linuxcore" sections: > > $ objdump -h ./testsuite/core.7452 > [...] > 3 .note.linuxcore.siginfo/7452 00000080 0000000000000000 0000000000000000 0000075c 2**2 > [...] > > And then we'd end up with a gdbarch that has > arm_linux_iterate_over_regset_sections installed, and thus no > crash. > Quite interesting, I'll investigate that and see if we can submit an improvement along those lines. Thanks!