Re: [PATCH V2 5/5] Support tracepoints for ARM linux in GDBServer

Yao Qi
2016-11-16T20:49:31Z

On Tue, Nov 15, 2016 at 2:36 PM, Antoine Tremblay
<antoine.tremblay@ericsson.com> wrote:
>>
>> This field is only useful to trap-based tracepoint. It signals that we
>> need to create a sub-class trap_based_tracepoint of struct tracepoint.
>>
>
> Currently struct tracepoint is a merged struct if you will of all the
> tracepoint types, fast, static, trap.
>
> Moving to a subclass for trap-based tracepoints, would require making a
> subclass for all the others too, static, fast. It would be quite
> inconsistent otherwise.

Yes, that is what we should do. Before we add something new, we need to
clean up the existing code if necessary.

>
> While I do not object to this change, I think it should be part of
> another patch series and that this change is orthogonal to the
> tracepoint support for arm.
>
> WDYT ?
>

It is not orthogonal to the tracepoint support. In contrary, we must
"sub-struct" or "sub-class" tracepoint first, and them add "kind"
field for trap-based tracepoint. Note that "struct tracepoint" is
used in IPA as well.

--
Yao (齐尧)