Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jason Merrill <jason@redhat.com>
To: gdb-patches@sources.redhat.com
Cc: Jason Merrill <jason@redhat.com>
Subject: PATCH to stabsread.c:read_member_functions
Date: Thu, 17 Jan 2002 07:07:00 -0000	[thread overview]
Message-ID: <wvlk7uh819y.fsf@prospero.cambridge.redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 648 bytes --]

This patch fixes gdb.c++/classes.exp:ptype Static when used with gcc 3.x
and stabs output.  The code in question was never correct, just a likely
guess; in particular, it got things wrong even with the v2 output for
Static::ii, where the plain function name ("ii") was the same as the
mangled form of the argument list (int, int == "ii").  For v3, we don't try
to do minimal output, so it will always guess wrong.

OK?  Should I just remove the bad code rather than comment it out?

2002-01-17  Jason Merrill  <jason@redhat.com>

	* stabsread.c (read_member_functions): Never guess that the given
	physname for a static member function is a stub.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 691 bytes --]

*** stabsread.c.~1~	Wed Jan 16 18:52:33 2002
--- stabsread.c	Thu Jan 17 15:01:35 2002
*************** read_member_functions (struct field_info
*** 3206,3216 ****
--- 3206,3221 ----
  	    case '?':
  	      /* static member function.  */
  	      new_sublist->fn_field.voffset = VOFFSET_STATIC;
+ #if 0
+ 	      /* This was a kludge to try to get the right answer for gcc
+ 		 v2 stabs output.  In v3 we don't try to avoid writing out
+ 		 full mangled names, so this just causes problems.  */
  	      if (strncmp (new_sublist->fn_field.physname,
  			   main_fn_name, strlen (main_fn_name)))
  		{
  		  new_sublist->fn_field.is_stub = 1;
  		}
+ #endif
  	      break;
  
  	    default:

             reply	other threads:[~2002-01-17 15:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-01-17  7:07 Jason Merrill [this message]
2002-01-17  7:14 ` Daniel Jacobowitz
2002-01-17  7:15 ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=wvlk7uh819y.fsf@prospero.cambridge.redhat.com \
    --to=jason@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox