RE: [PATCH] Fix mi "-var-create" regression

Marc Khouzam
2012-11-15T16:44:51Z

> -----Original Message-----
> From: gdb-patches-owner@sourceware.org
> [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Luis Machado
> Sent: Wednesday, November 14, 2012 2:22 PM
> To: Tom Tromey
> Cc: Joel Brobecker; gdb-patches@sourceware.org
> Subject: Re: [PATCH] Fix mi "-var-create" regression
>
> On 10/30/2012 06:36 PM, Tom Tromey wrote:
> >>>>>> "Luis" == Luis Machado<lgustavo@codesourcery.com> writes:
> >
> > Luis> 2012-10-15 Luis Machado<lgustavo@codesourcery.com>
> > Luis> * value.c (value_actual_type): Check for
> TYPE_CODE_STRUCT
> > Luis> target types.
> >
> > Luis> testsuite/
> > Luis> * mi-var-create-rtti.c: New file.
> > Luis> * mi-var-create-rtti.exp: New file.
> >
> > This looks good to me. One tiny nit:
> >
> > Luis> Index: gdb/gdb/testsuite/gdb.mi/mi-var-create-rtti.exp
> > Luis> + return -1;
> >
> > No need for a ";" here.
> >
> > Ok with this change.
> >
> > thanks,
> > Tom
>
> Thanks. I've checked this in now.

Nice!
Is it possible to put this in the 7_5 branch?

Thanks

Marc