From: Lancelot SIX <lancelot.six@amd.com>
To: Luis Machado <luis.machado@amd.com>
Cc: <lancelot.six@amd.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdb/testsuite: XFAIL watchpoint-basic for more gfx targets
Date: Wed, 16 Sep 2026 12:10:23 +0100 [thread overview]
Message-ID: <vx6ky3kosfzh5q6nxg5wk5skno3d6dohoymrwqxt4rvuvvo6uv@5ohk3oxi5khu> (raw)
In-Reply-To: <20260916110136.646558-1-luis.machado@amd.com>
On Wed, Sep 16, 2026 at 06:01:36AM -0500, Luis Machado wrote:
> Add gfx1100, gfx1101, gfx1151 and gfx1200 to the list of architectures that
> are expected to fail in watchpoint-basic.exp due to watchpoint
> configuration corruption in kfd.
>
> ---
> gdb/testsuite/gdb.rocm/watchpoint-basic.exp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/testsuite/gdb.rocm/watchpoint-basic.exp b/gdb/testsuite/gdb.rocm/watchpoint-basic.exp
> index cd29d856d56..17cf533a107 100644
> --- a/gdb/testsuite/gdb.rocm/watchpoint-basic.exp
> +++ b/gdb/testsuite/gdb.rocm/watchpoint-basic.exp
> @@ -96,7 +96,7 @@ proc_with_prefix test_host_watchpoint_after_runtime_load {} {
> # end and exit prematurely.
>
> gdb_caching_proc target_has_xfail {} {
> - set xfail_arches {gfx1103 gfx1201}
> + set xfail_arches {gfx1100 gfx1101 gfx1103 gfx1151 gfx1200 gfx1201}
(with gdb-patches@ copied this time)
We can probably add gfx1150 here as well, I suspect it should behave the
same.
With this, this LGTM.
Best,
Laneclot.
Approved-by: Lancelot Six <lancelot.six@amd.com> (amdgpu)
>
> set targets [find_amdgpu_devices]
> if {[llength $targets] == 0} {
> --
> 2.43.0
prev parent reply other threads:[~2026-09-16 11:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 11:01 Luis Machado
2026-09-16 11:10 ` Lancelot SIX [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vx6ky3kosfzh5q6nxg5wk5skno3d6dohoymrwqxt4rvuvvo6uv@5ohk3oxi5khu \
--to=lancelot.six@amd.com \
--cc=gdb-patches@sourceware.org \
--cc=luis.machado@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox