From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-27436-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 8118 invoked by alias); 30 Sep 2003 22:18:07 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 8070 invoked from network); 30 Sep 2003 22:18:06 -0000
Received: from unknown (HELO zenia.home) (12.223.225.216)
  by sources.redhat.com with SMTP; 30 Sep 2003 22:18:06 -0000
Received: by zenia.home (Postfix, from userid 5433)
	id 3D37820766; Tue, 30 Sep 2003 17:13:49 -0500 (EST)
To: Michael Elizabeth Chastain <mec@shout.net>
Cc: ac131313@redhat.com, carlton@kealia.com, fnasser@redhat.com,
	gdb-patches@sources.redhat.com
Subject: Re: RFA: Don't include value of expression in pc-fp.exp test name
References: <200309301749.h8UHnZkE029086@duracef.shout.net>
From: Jim Blandy <jimb@redhat.com>
Date: Tue, 30 Sep 2003 22:18:00 -0000
In-Reply-To: <200309301749.h8UHnZkE029086@duracef.shout.net>
Message-ID: <vt2znglncv6.fsf@zenia.home>
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2003-09/txt/msg00670.txt.bz2


Michael Elizabeth Chastain <mec@shout.net> writes:

> Yeah!  It makes my life easier!
> 
> You need to add '2003' to the copyright year to the top of pc-fp.exp.
> 
> Proofread.  Tested on my test bed with 10 configurations.
> All the gdb.sum's come out identical now.

Fantastic.  I think this deserves mention in NEWS.

2003-09-30  Jim Blandy  <jimb@redhat.com>

	* gdb.base/pc-fp.exp (get_valueofx): Don't include the value of
	the expression in the pass message.  This just creates spurious
	differences in summary files.

Index: gdb/testsuite/gdb.base/pc-fp.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/pc-fp.exp,v
retrieving revision 1.1
diff -c -r1.1 pc-fp.exp
*** gdb/testsuite/gdb.base/pc-fp.exp	25 Sep 2002 20:30:38 -0000	1.1
--- gdb/testsuite/gdb.base/pc-fp.exp	30 Sep 2003 22:15:22 -0000
***************
*** 1,4 ****
! #   Copyright 2002 Free Software Foundation, Inc.
  
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
--- 1,4 ----
! #   Copyright 2002, 2003 Free Software Foundation, Inc.
  
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
***************
*** 62,68 ****
      gdb_expect {
  	-re "\\$\[0-9\]* = (0x\[0-9a-zA-Z\]+).*$gdb_prompt $" {
  	    set val $expect_out(1,string)
! 	    pass "get value of ${exp} ($val)"
  	}
  	timeout {
  	    set size ${default}
--- 62,68 ----
      gdb_expect {
  	-re "\\$\[0-9\]* = (0x\[0-9a-zA-Z\]+).*$gdb_prompt $" {
  	    set val $expect_out(1,string)
! 	    pass "get value of ${exp}"
  	}
  	timeout {
  	    set size ${default}