From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6102 invoked by alias); 17 Jun 2004 21:11:31 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6090 invoked from network); 17 Jun 2004 21:11:29 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 17 Jun 2004 21:11:29 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i5HLBTe1016329 for ; Thu, 17 Jun 2004 17:11:29 -0400 Received: from zenia.home.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i5HLBR024574; Thu, 17 Jun 2004 17:11:27 -0400 To: mec.gnu@mindspring.com CC: gdb-patches@sources.redhat.com Subject: Re: RFA: gdb.base/charset.exp: tighten regexp for ^C References: From: Jim Blandy Date: Thu, 17 Jun 2004 21:11:00 -0000 In-Reply-To: Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2004-06/txt/msg00424.txt.bz2 Ping? I reported the systems on which I tested it in a followup message. http://sources.redhat.com/ml/gdb-patches/2004-06/msg00064.html Jim Blandy writes: > The problem with the regexp for the clause that sends ^C is that it > matches a prefix of the correct output. If expect sees GDB's output > arrive in small chunks, then that clause can trigger even when GDB is > behaving correctly. This happens on AIX. > > I didn't see any discussion in the archives of the sort of situations > this clause was meant to handle. A different approach might be for > the timeout clause to send a ^C the first time around, and then > actually fail the second time around. Then the situation the clause > the patch tweaks was meant to handle (now there's a nice noun clause) > will be caught by the ordinary $gdb_prompt case. > > 2004-06-03 Jim Blandy > > * gdb.base/charset.exp: Only send a control-C if we see a new > prompt and incomplete command. > > Index: gdb/testsuite/gdb.base/charset.exp > =================================================================== > RCS file: /cvs/src/src/gdb/testsuite/gdb.base/charset.exp,v > retrieving revision 1.3 > diff -c -p -r1.3 charset.exp > *** gdb/testsuite/gdb.base/charset.exp 26 Feb 2004 17:23:23 -0000 1.3 > --- gdb/testsuite/gdb.base/charset.exp 4 Jun 2004 04:20:01 -0000 > *************** gdb_expect { > *** 140,146 **** > # We got some output that ended with a regular prompt > fail "get valid character sets" > } > ! -re "^set charset.*$" { > # We got some other output, send a cntrl-c to gdb to get us back > # to the prompt. > send_gdb "\003" > --- 140,146 ---- > # We got some output that ended with a regular prompt > fail "get valid character sets" > } > ! -re ".*$gdb_prompt set charset.*$" { > # We got some other output, send a cntrl-c to gdb to get us back > # to the prompt. > send_gdb "\003"