Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@redhat.com>
To: Daniel Jacobowitz <drow@mvista.com>
Cc: Elias Athanasopoulos <eathan@otenet.gr>,
	Michael Snyder <msnyder@redhat.com>,
	gdb-patches@sources.redhat.com
Subject: Re: [PATCH/RFC] faster language identification
Date: Wed, 13 Nov 2002 10:01:00 -0000	[thread overview]
Message-ID: <vt2wunhqs6p.fsf@zenia.red-bean.com> (raw)
In-Reply-To: <20021110190450.GA7860@nevyn.them.org>


Daniel Jacobowitz <drow@mvista.com> writes:
> On Sun, Nov 10, 2002 at 05:01:25PM +0200, Elias Athanasopoulos wrote:
> > Hi Michael,
> > 
> > On Thu, Nov 07, 2002 at 12:55:47PM -0800, Michael Snyder wrote:
> > > Elias Athanasopoulos wrote:
> > > > On Thu, Nov 07, 2002 at 02:48:38PM -0500, Daniel Jacobowitz wrote:
> > > > > No, the patch converts the psymtab to a symtab and uses the language in
> > > > > the symtab.  That's what I want you NOT to do.  psymtab_to_symtab is
> > > > > expensive!
> > > Perhaps the patch could be added to psymtab_to_symtab, 
> > > so that it would not try to get the language until 
> > > the symbols were going to be read anyway?
> > 
> > Yes, that may work, although I don't know exactly where gdb *really* needs
> > to set the language.
> > 
> > I was thinking of what Daniel proposed; a psymtab_language() function. But,
> > even in the DWARF case, consider this:
> > 
> > % gcc -Wa,-gdwarf2 bar.s foo.c -o foo
> > 
> > Now, the language should be set to 'asm'? This is what you'll get if you try
> > to parse the .debug_info section. Currently, gdb in the above case sets it
> > to 'c'.
> > 
> > Also, there is the case that you enable DWARF in both as and gcc, but I think
> > this shouldn't be allowed by gcc.
> 
> Well, it _should_ be asm.  We don't have line number information for
> the .c source.  IMHO.
> 
> (Also IMHO, the user just shouldn't do that...)

Shouldn't do what?  Compile assembly with debug info?  Link object
modules with a mix of debuggingness?  I don't see what's wrong...

The right behavior here, it seems to me, depends on which module
contains 'main'.  If that module has debug info, we should use that to
choose the initial language; otherwise, we can guess from the source
filename.  Even .c files compiled without debugging info have a .file
directive in the assembly code, which turns into an STT_FILE linker
symbol.


  reply	other threads:[~2002-11-13 18:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-07 11:26 Elias Athanasopoulos
2002-11-07 11:33 ` Daniel Jacobowitz
2002-11-07 11:43   ` Elias Athanasopoulos
2002-11-07 11:47     ` Daniel Jacobowitz
2002-11-07 11:58       ` Elias Athanasopoulos
2002-11-07 12:55         ` Michael Snyder
2002-11-10  5:43           ` Elias Athanasopoulos
2002-11-10 11:03             ` Daniel Jacobowitz
2002-11-13 10:01               ` Jim Blandy [this message]
2002-11-13 10:11                 ` Daniel Jacobowitz
2002-11-13 10:39                   ` Jim Blandy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vt2wunhqs6p.fsf@zenia.red-bean.com \
    --to=jimb@redhat.com \
    --cc=drow@mvista.com \
    --cc=eathan@otenet.gr \
    --cc=gdb-patches@sources.redhat.com \
    --cc=msnyder@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox