Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@codesourcery.com>
To: fnf@specifix.com
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Patch to skip_prologue_using_sal() for oneline stub functions
Date: Wed, 10 May 2006 22:22:00 -0000	[thread overview]
Message-ID: <vt2wtctwmf7.fsf@theseus.home.> (raw)
In-Reply-To: <200605101113.50267.fnf@specifix.com> (Fred Fish's message of "Wed, 10 May 2006 11:13:50 -0400")


Fred Fish <fnf@specifix.com> writes:
> If a function optimizes down to a single return instruction, there is
> no prologue, and skip_prologue_using_sal will return a PC that is
> probably the first instruction of the next following function.  In
> this case, we want to return the start_pc, so that the caller will
> know that it needs to run the architecture specific prologue scanner
> to figure out what is going on.
>
> This fixes the following failures for MIPS:
>
>   FAIL: gdb.base/break.exp: breakpoint small function, optimized file
>   FAIL: gdb.base/break.exp: run until function breakpoint, optimized file
>   FAIL: gdb.base/break.exp: run until breakpoint set at small function, optimized file
>
> -Fred
>
> ============================================================================
>
> 2006-05-10  Fred Fish  <fnf@specifix.com>
>
> 	* symtab.c (skip_prologue_using_sal): Handle single line functions
> 	like "foo(){}", which may optimize down to a single return inst.

This looks reasonable; have you tested on IA-32, too?


  reply	other threads:[~2006-05-10 22:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-10 15:13 Fred Fish
2006-05-10 22:22 ` Jim Blandy [this message]
2006-05-11  0:58   ` Fred Fish
2006-05-11  4:11     ` Jim Blandy
2006-05-13  9:47 ` Mark Kettenis
2006-05-13 20:04   ` Fred Fish

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vt2wtctwmf7.fsf@theseus.home. \
    --to=jimb@codesourcery.com \
    --cc=fnf@specifix.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox