Re: [PATCH] S/390 port modernization 1/4

Jim Blandy
2003-12-04T21:18:08Z

The rearrangement of the register code looks great. I did core file
register handling in Not The Right Fashion, and your new code seems to
fix that. And it's more legible.

It seems like s390-nat.c's s390_gregset_regmap and
s390_fpregset_regmap are essentially the same information as
s390-tdep.c's s390_regmap_gregset, s390x_regmap_gregset, and
s390_regmap_fpregset, except that the s390 / s390x distinction is
static in s390-nat.c, and dynamic in s390-tdep.c. But if I recall
correctly, the way the types in the kernel header files work out, the
core dump format is always the same as the PTRACE uarea format.

Would it be possible to have s390-nat.c simply use the structures from
s390-tdep.c? There's nothing wrong with having an s390-tdep.h file in
the gdb directory; that's the usual arrangement for native systems.

But this is a minor issue. Given the nature of the IBM / FSF process,
feel free to either revise this patch, or submit it as a separate
patch, whichever is easiest for you.