Re: [PATCH] S/390 port modernization 1/4

Ulrich Weigand
2003-12-04T21:56:25Z

Jim Blandy wrote:

> The deletion of the #undefinition of SKIP_TRAMPOLINE_CODE isn't
> mentioned in the ChangeLog entries; was it intentional? If I'm
> following the code right, the effect is to change the method from
> using generic_skip_trampoline_code (the gdbarch default) to using
> find_solib_trampoline_target (#defined in config/tm-sysv4.h, #included
> from config/tm-linux.h, #included from config/s390/tm-linux.h), so it
> seems like something that deserves mention.

Hmm, I probably misinterpreted the comment above that line ...

In any case, looking at the code, it certainly seems the right
thing to do to use the same SKIP_TRAMPOLINE_CODE as other Linux
ports, since everything related to PLTs works the same on s390
as elsewhere.

So I'd suggest to leave the patch as is in that regard, and simply
add a ChangeLog line.

Bye,
Ulrich

--
Dr. Ulrich Weigand
weigand@informatik.uni-erlangen.de