Re: [PATCH] S/390 port modernization 1/4

Jim Blandy
2003-12-04T21:01:49Z

Ulrich Weigand <weigand@i1.informatik.uni-erlangen.de> writes:
> *** gdb-head/gdb/config/s390/tm-linux.h Tue Dec 2 17:47:36 2003
> --- gdb-head-new/gdb/config/s390/tm-linux.h Tue Dec 2 16:36:15 2003
> ***************
> *** 25,42 ****
> #ifndef TM_LINUX_H
> #define TM_LINUX_H
>
> - #undef TARGET_ELF64
> - #define TARGET_ELF64 (gdbarch_tdep (current_gdbarch)->intreg_size==8)
> -
> #include "config/tm-linux.h"
>
> - /* Zap several macros defined in the above header so that multi-arch
> - can safely re-define them. The ``correct fix'' involves
> - eliminating either the above include or even this file. */
> - #undef SKIP_TRAMPOLINE_CODE
> -
> - #include "s390/tm-s390.h"
> -
> -
> -
> #endif /* TM_LINUX_H */
> --- 25,30 ----

The deletion of the #undefinition of SKIP_TRAMPOLINE_CODE isn't
mentioned in the ChangeLog entries; was it intentional? If I'm
following the code right, the effect is to change the method from
using generic_skip_trampoline_code (the gdbarch default) to using
find_solib_trampoline_target (#defined in config/tm-sysv4.h, #included
from config/tm-linux.h, #included from config/s390/tm-linux.h), so it
seems like something that deserves mention.