Re: [PATCH] S/390 port modernization 1/4

Jim Blandy
2003-12-04T21:43:08Z

The regset_from_core_section stuff is done exactly the way the i386
and x86-64 do it, so I won't criticize it. But there are two things I
wonder about:

- Since core file formats are really OS-specific (ABI's often don't
specify them), wouldn't it make more sense for the *-nat.c file to
register an OS/ABI handler, and have that handler register the
regset_from_core_section method?

- Why does everyone allocate the 'struct regset' objects dynamically?
The regset layouts are structures in header files, so there's only a
static set of them; one could simply define initialized instances of
'struct regset', and the regset_from_core_section method could
return them. That seems simpler than allocating them dynamically,
and caching them in the tdep structure.