Re: [PATCH] i386_stab_reg_to_regnum (4 <-> 5, ebp <-> esp)

Brian Ford
2004-04-06T14:53:56Z

On Mon, 5 Apr 2004, Jim Blandy wrote:

> Brian Ford writes:
> > ... I still propose we rename the _to_regnum functions, replacing
> > stabs and dwarf with dbx and svr4 to reduce confusion. I'll be happy to
> > make a patch :-).
>
> I agree that would be better.
>
> (I should make it clear that I can't approve this patch. We need Mark
> Kettenis's okay.)

Ok, I'll submit a patch after this thread is resolved.

> > On Mon, 5 Apr 2004, Jim Blandy wrote:
> > > It's true that the comments for svr4_dbx_register_map in
> >
> > Just svr4_register_map (so noone gets confused).
>
> Really? I'm looking at revision 1.660 of gcc/config/i386/i386.c, like
> 657:
>
> int const svr4_dbx_register_map[FIRST_PSEUDO_REGISTER] =
>
> Not to be "back-atcha" or anything like that; this is just such a maze
> of twisty little...

You are correct. I guess I was just having an off day and I got it stuck
in my head wrong.

> > > ... every i386 GCC configuration uses either dbx_register_map or
> > > svr4_dbx_register_map for both debug formats.
> >
> > Agreed. I'm happy to stick with dbx_register_map on Cygwin for all debug
> > formats if a version of my patch is accepted. DWARF 2 (and STABS) will
> > work fine then. And, I'd be glad to help Eli sort through the
> > ramifications, since his is just about the only target to be affected.
>
> Sounds great.

Now we just need some words from Eli and an approval for your version of
my patch, I think.

--
Brian Ford
Senior Realtime Software Engineer
VITAL - Visual Simulation Systems
FlightSafety International
Phone: 314-551-8460
Fax: 314-551-8444