From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8651 invoked by alias); 4 Nov 2002 21:19:22 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8643 invoked from network); 4 Nov 2002 21:19:21 -0000 Received: from unknown (HELO zenia.red-bean.com) (66.244.67.22) by sources.redhat.com with SMTP; 4 Nov 2002 21:19:21 -0000 Received: (from jimb@localhost) by zenia.red-bean.com (8.11.6/8.11.6) id gA4L4ib17797; Mon, 4 Nov 2002 16:04:44 -0500 To: David Edelsohn Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] C++ Dwarf2 inner scope PR/789 References: <200210102027.QAA26250@makai.watson.ibm.com> <200210282137.QAA31170@makai.watson.ibm.com> From: Jim Blandy Date: Mon, 04 Nov 2002 13:19:00 -0000 In-Reply-To: <200210282137.QAA31170@makai.watson.ibm.com> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2.90 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-11/txt/msg00033.txt.bz2 David Edelsohn writes: > Any status on PR gdb/789 and the patch earlier in this thread? I think the patch breaks into two parts: First, restoring local_symbols and param_symbols from the popped context seems right. That's a two-line fix, so I'll just make it myself, with credit to you. I think restoring prev_list_in_scope can be done more simply, by checking whether context_stack is empty: if it is, then the list in scope is file_symbols; otherwise, it's local_symbols. However, I've seen some odd behavior when running your test case that I want to understand before I proceed with this. I appreciate your patience.