Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: RFA: fix formatting of 'p' packet register number
Date: Thu, 07 Oct 2004 22:33:00 -0000	[thread overview]
Message-ID: <vt2sm8qp3aa.fsf@zenia.home> (raw)


2004-10-07  Jim Blandy  <jimb@redhat.com>

	* remote.c (fetch_register_using_p): Construct 'p' packet in a
	manner independent of the host byte order.

Index: gdb/remote.c
===================================================================
RCS file: /cvs/src/src/gdb/remote.c,v
retrieving revision 1.149
diff -c -p -r1.149 remote.c
*** gdb/remote.c	5 Oct 2004 19:52:04 -0000	1.149
--- gdb/remote.c	7 Oct 2004 22:31:11 -0000
*************** fetch_register_using_p (int regnum)
*** 3176,3184 ****
    char regp[MAX_REGISTER_SIZE];
    int i;
  
!   buf[0] = 'p';
!   bin2hex((char *) &regnum, &buf[1], sizeof(regnum));
!   buf[9] = 0;
    remote_send (buf, rs->remote_packet_size);
    if (buf[0] != 0 && buf[0] != 'E') {
       p = buf;
--- 3176,3185 ----
    char regp[MAX_REGISTER_SIZE];
    int i;
  
!   p = buf;
!   *p++ = 'p';
!   p += hexnumstr (p, regnum);
!   *p++ = '\0';
    remote_send (buf, rs->remote_packet_size);
    if (buf[0] != 0 && buf[0] != 'E') {
       p = buf;


             reply	other threads:[~2004-10-07 22:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-07 22:33 Jim Blandy [this message]
2004-10-25 23:10 ` Andrew Cagney
2004-10-27 22:35   ` Jim Blandy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vt2sm8qp3aa.fsf@zenia.home \
    --to=jimb@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox