Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@redhat.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFA: general prologue analysis framework
Date: Fri, 14 Oct 2005 18:13:00 -0000	[thread overview]
Message-ID: <vt2slv47ys8.fsf@theseus.home.> (raw)
In-Reply-To: <200510131748.j9DHm1eW002511@53v30g15.boeblingen.de.ibm.com> (Ulrich Weigand's message of "Thu, 13 Oct 2005 19:48:01 +0200 (CEST)")


Ulrich Weigand <uweigand@de.ibm.com> writes:
>> It looks like your data->gpr_slot[i] array effectively serves the same
>> purpose as an area.  If we had generic code to scan an area and
>> populate a trad_frame_cache, areas might save you code.
>
> Possibly, yes.  I'm not sure I completely understand the pv_area code
> yet -- it appears to be all based on the notion of a fixed base register;
> how to you handle the situation where the base (and/or offset) used to
> access the area change in the middle of the prologue?  Maybe it would
> be better to always base the area on the CFA ...

The comment for make_pv_area was misleading.  Here's a better comment:

    /* Create a new area, tracking stores relative to the original value
       of BASE_REG.  Stores to constant addresses, unknown addresses, or
       to addresses relative to registers other than BASE_REG will trash
       this area; see pv_area_store_would_trash.  */
    struct pv_area *make_pv_area (int base_reg);

So if you pass the SP as the base register, the CFA is exactly what
you get.  The CFA must always be a constant offset from the incoming
value of the SP.  The CFA is constant for a given call, and the
incoming value of the SP is also a constant for a given call, simply
because registers have only one value at a time.  So their difference
must be a constant.


  parent reply	other threads:[~2005-10-14 18:13 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-07 20:39 Jim Blandy
2005-10-07 21:25 ` Nathan J. Williams
2005-10-07 21:30   ` Daniel Jacobowitz
2005-10-07 21:41     ` Nathan J. Williams
2005-10-08  7:02       ` Jim Blandy
2005-10-08  7:01   ` Jim Blandy
2005-10-08 16:00     ` Daniel Jacobowitz
2005-10-09 20:27 ` Daniel Jacobowitz
2005-10-13  0:20   ` Jim Blandy
2005-10-13  1:04     ` Daniel Jacobowitz
2005-10-13 13:50     ` Ulrich Weigand
2005-10-13 17:17       ` Jim Blandy
2005-10-13 17:48         ` Ulrich Weigand
2005-10-13 18:03           ` Daniel Jacobowitz
2005-10-14 18:13           ` Jim Blandy [this message]
2005-10-17 18:52             ` Ulrich Weigand
2005-10-17 20:28               ` Jim Blandy
2005-11-23  2:56                 ` Ulrich Weigand
2005-10-15 12:12 ` Eli Zaretskii
2005-10-17 20:32   ` Jim Blandy
2005-10-19  8:55     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vt2slv47ys8.fsf@theseus.home. \
    --to=jimb@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox