From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22910 invoked by alias); 15 Aug 2002 22:04:33 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22703 invoked from network); 15 Aug 2002 22:04:31 -0000 Received: from unknown (HELO zenia.red-bean.com) (66.244.67.22) by sources.redhat.com with SMTP; 15 Aug 2002 22:04:31 -0000 Received: (from jimb@localhost) by zenia.red-bean.com (8.11.6/8.11.6) id g7FLsWa11221; Thu, 15 Aug 2002 16:54:32 -0500 To: Petr Sorfa Cc: "gdb-patches@sources.redhat.com" Subject: Re: [RFA] DWARF multiple comp unit header support - Revision - Part 1 References: <3D2F0E4F.DDCC4DE9@caldera.com> From: Jim Blandy Date: Thu, 15 Aug 2002 15:04:00 -0000 In-Reply-To: <3D2F0E4F.DDCC4DE9@caldera.com> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2.90 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-08/txt/msg00386.txt.bz2 This looks good. Some comments: Petr Sorfa writes: > 2002-07-12 Petr Sorfa (petrs@caldera.com) > > * dwarf2read.c (ABBREV_HASH_SIZE): moved definition > forward in the code to be defined before > struct comp_unit_head. > (comp_unit_head): Added several new members, > some are being used with this patch, some not. > offset - Offset of the cu_header in .debug_info > begin_offset - Base offset of cu_header into program > next - Next comp unit head in program > dwarf2_abbrevs - abbreviation tables associated with > comp unit header. The members must be documented in the code, and thus need only be named in the ChangeLog entry. > *************** struct comp_unit_head > *** 174,179 **** > --- 179,194 ---- > unsigned int offset_size; /* size of file offsets; either 4 or 8 */ > unsigned int initial_length_size; /* size of the length field; either > 4 or 12 */ > + > + /* New information for the comp unit head so as to keep a list > + of available ones for a program. */ > + unsigned int offset; /* Offset of the cu_header in .debug_info */ > + char *base_offset; /* Base offset after cu_header into program */ > + char *begin_offset; /* Base offset of cu_header into program */ > + struct comp_unit_head *next; /* Next comp unit head in program */ > + > + struct abbrev_info *dwarf2_abbrevs[ABBREV_HASH_SIZE]; /* DWARF abbrev > + table */ > }; > > /* The line number information for a compilation unit (found in the These comments need to be much more expansive. It's very important that data structures be clearly explained. How is "Base offset *after* cu_header into program" different from "Base offset *of* cu_header into program"? Have you compared test suite results with and without this patch?