From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-35453-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 31504 invoked by alias); 25 Aug 2004 05:07:47 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 31439 invoked from network); 25 Aug 2004 05:07:46 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sourceware.org with SMTP; 25 Aug 2004 05:07:46 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i7P57kS0021324
	for <gdb-patches@sources.redhat.com>; Wed, 25 Aug 2004 01:07:46 -0400
Received: from zenia.home.redhat.com (porkchop.devel.redhat.com [172.16.58.2])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i7P57i328760;
	Wed, 25 Aug 2004 01:07:44 -0400
To: Andrew Cagney <cagney@gnu.org>, Mark Kettenis <kettenis@jive.nl>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: Support libthread_db xregs interface
References: <vt2pt5wvsjf.fsf@zenia.home> <412A55E8.3060100@gnu.org>
From: Jim Blandy <jimb@redhat.com>
Date: Wed, 25 Aug 2004 05:07:00 -0000
In-Reply-To: <412A55E8.3060100@gnu.org>
Message-ID: <vt2oekzkdqc.fsf@zenia.home>
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2004-08/txt/msg00684.txt.bz2


Andrew Cagney <cagney@gnu.org> writes:
> > + v:=:const struct regset *:xregs_regset:::0
> 
> Mark's regset change added both the "regset.h" object and the
> regset_from_core_section architecture method.  They, together, replace
> the old *-nat.c:fill_regset et.al. calls.
> 
> Can we implement the equivalent here for ptrace/thread-db?

Not sure what you mean.  This change lets a gdbarch object specify a
regset which the libthread_db support code will then use to read and
write additional registers beyond those covered by gregset_t and
fpregset_t.  So this change does provide a regset.h-style regset for
libthread_db.  That's what you're looking for, right?

> Instead of:
> > +           if (! warned_xregs_not_implemented)
> > +             {
> > +               warning ("thread debugging library is too old to access "
> > +                        "%s registers.",
> > +                        gdbarch_xregs_name (current_gdbarch));
> can we use "complaint".  That "thread" should be "Thread".

Sure.

> > + v:=:int:xregs_size:::0
> > + v:=:const char *:xregs_name:::0
> 
> I gather these were fields in the original xreg_desc object but are
> missing from the "regset"?  Should these, instead be added to the
> regset, or a new object extending regset created?

I was wondering about that, too.  It'd certainly be neater.  Mark,
what's your take on this?