From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17962 invoked by alias); 21 Sep 2004 06:26:46 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17950 invoked from network); 21 Sep 2004 06:26:45 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 21 Sep 2004 06:26:45 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.10) with ESMTP id i8L6QjEk005195 for ; Tue, 21 Sep 2004 02:26:45 -0400 Received: from zenia.home.redhat.com (sebastian-int.corp.redhat.com [172.16.52.221]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i8L6Qir26230; Tue, 21 Sep 2004 02:26:44 -0400 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [rfa/intercu] Preserve DIE types References: <20040921023139.GA25706@nevyn.them.org> From: Jim Blandy Date: Tue, 21 Sep 2004 06:26:00 -0000 In-Reply-To: <20040921023139.GA25706@nevyn.them.org> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2004-09/txt/msg00336.txt.bz2 Daniel Jacobowitz writes: > The only solution I could find was to cache this information, specifically > the DIE -> type mapping. I think that's the only correct thing to do. > Tested on i686-pc-linux-gnu. OK? It looks fine. Just one question: in set_die_type, why do you check whether cu->per_cu is NULL? Under what circumstances would we be associating types to dies in a compilation unit that is not considered "read in"?