From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-35902-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 8314 invoked by alias); 21 Sep 2004 15:03:29 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 8115 invoked from network); 21 Sep 2004 15:03:23 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sourceware.org with SMTP; 21 Sep 2004 15:03:23 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.11/8.12.10) with ESMTP id i8LF3Dvf019247
	for <gdb-patches@sources.redhat.com>; Tue, 21 Sep 2004 11:03:23 -0400
Received: from zenia.home.redhat.com (sebastian-int.corp.redhat.com [172.16.52.221])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i8LF37r20793;
	Tue, 21 Sep 2004 11:03:07 -0400
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa/intercu] Preserve DIE types
References: <20040921023139.GA25706@nevyn.them.org>
	<vt2oek09m0l.fsf@zenia.home> <20040921125116.GA9804@nevyn.them.org>
From: Jim Blandy <jimb@redhat.com>
Date: Tue, 21 Sep 2004 15:03:00 -0000
In-Reply-To: <20040921125116.GA9804@nevyn.them.org>
Message-ID: <vt2oejz64z5.fsf@zenia.home>
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2004-09/txt/msg00340.txt.bz2


Daniel Jacobowitz <drow@false.org> writes:
> On Tue, Sep 21, 2004 at 01:25:14AM -0500, Jim Blandy wrote:
> > 
> > Daniel Jacobowitz <drow@false.org> writes:
> > > The only solution I could find was to cache this information, specifically
> > > the DIE -> type mapping.
> > 
> > I think that's the only correct thing to do.
> > 
> > > Tested on i686-pc-linux-gnu.  OK?
> > 
> > It looks fine.  Just one question: in set_die_type, why do you check
> > whether cu->per_cu is NULL?  Under what circumstances would we be
> > associating types to dies in a compilation unit that is not considered
> > "read in"?
> 
> cu->per_cu != NULL is the flag which indicates that we've seen an
> inter-compilation-unit reference.  If we haven't, then we'll read in
> this compilation unit but discard it completely when we're done with
> it.

Okay, that's right --- based on the forms we see used in the abbrev
table.  Thanks.  All good, then.