Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: PATCH: remove unused variables and code in value_assign
Date: Tue, 14 Sep 2004 03:02:00 -0000	[thread overview]
Message-ID: <vt2mzzt5z9q.fsf@zenia.home> (raw)


Committed as obvious.

2004-09-13  Jim Blandy  <jimb@redhat.com>

	* valops.c (value_assign): 'use_buffer' is initialized to zero,
	and never assigned to.   Delete it, and the 'if (use_buffer)'
	clauses.  Delete 'raw_buffer', since it is now unused.

Index: gdb/valops.c
===================================================================
RCS file: /cvs/src/src/gdb/valops.c,v
retrieving revision 1.130
diff -c -p -r1.130 valops.c
*** gdb/valops.c	14 Sep 2004 02:51:27 -0000	1.130
--- gdb/valops.c	14 Sep 2004 02:58:34 -0000
*************** value_assign (struct value *toval, struc
*** 525,532 ****
  {
    struct type *type;
    struct value *val;
-   char raw_buffer[MAX_REGISTER_SIZE];
-   int use_buffer = 0;
    struct frame_id old_frame;
  
    if (!toval->modifiable)
--- 525,530 ----
*************** value_assign (struct value *toval, struc
*** 591,602 ****
  	    changed_addr = VALUE_ADDRESS (toval) + VALUE_OFFSET (toval);
  	    dest_buffer = buffer;
  	  }
- 	else if (use_buffer)
- 	  {
- 	    changed_addr = VALUE_ADDRESS (toval) + VALUE_OFFSET (toval);
- 	    changed_len = use_buffer;
- 	    dest_buffer = raw_buffer;
- 	  }
  	else
  	  {
  	    changed_addr = VALUE_ADDRESS (toval) + VALUE_OFFSET (toval);
--- 589,594 ----
*************** value_assign (struct value *toval, struc
*** 683,690 ****
  	      modify_field (buffer + byte_offset,
  			    value_as_long (fromval),
  			    VALUE_BITPOS (toval), VALUE_BITSIZE (toval));
- 	    else if (use_buffer)
- 	      memcpy (buffer + VALUE_OFFSET (toval), raw_buffer, use_buffer);
  	    else
  	      memcpy (buffer + byte_offset, VALUE_CONTENTS (fromval),
  		      TYPE_LENGTH (type));
--- 675,680 ----


                 reply	other threads:[~2004-09-14  3:02 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vt2mzzt5z9q.fsf@zenia.home \
    --to=jimb@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox