From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-27683-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 18824 invoked by alias); 8 Oct 2003 19:15:56 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 18814 invoked from network); 8 Oct 2003 19:15:55 -0000
Received: from unknown (HELO zenia.home) (12.223.225.216)
  by sources.redhat.com with SMTP; 8 Oct 2003 19:15:55 -0000
Received: by zenia.home (Postfix, from userid 5433)
	id ED13D207A2; Wed,  8 Oct 2003 14:14:30 -0500 (EST)
To: Daniel Jacobowitz <drow@mvista.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFC: Use program_transform_name correctly
References: <20031007225305.GA13082@nevyn.them.org>
	<20031007235921.8FB0B158F81@kanga.canids.net>
	<20031008010510.GA15693@nevyn.them.org>
From: Jim Blandy <jimb@redhat.com>
Date: Wed, 08 Oct 2003 19:15:00 -0000
In-Reply-To: <20031008010510.GA15693@nevyn.them.org>
Message-ID: <vt2llrvee3t.fsf@zenia.home>
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2003-10/txt/msg00244.txt.bz2

Daniel Jacobowitz <drow@mvista.com> writes:

> On Tue, Oct 07, 2003 at 04:59:21PM -0700, Felix Lee wrote:
> > Daniel Jacobowitz <drow@mvista.com>:
> > > Eh, you're right, this will teach me to answer without looking.  From
> > > gcc/Makefile.in:
> > >        t='$(program_transform_cross_name)'; echo ar | sed -e $$t ; \
> > > That's the idiom we should use here.
> > 
> > yeah, $$t should be unquoted because configure does the quoting,
> > so that a transformation that has quotes will work correctly.
> > however, this is only for "recent" versions of autoconf, where
> > recent is "some version of autoconf after 2.13 that still says
> > 'generated by 2.13' at the top of configure".
> > 
> > autoconf 2.13 and before will sometimes leave
> > program_transform_name null, which will cause that sed to fail.
> 
> How horrid.
> 
> > the newer autoconfs will make sure program_transform_name is
> > 's,x,x,' if it would otherwise be null.
> 
> Conveniently this is no longer an issue in the src repository (or in
> gcc).  The toplevel configure script now guarantees that
> $(program_transform_name) will not be empty.  So $$t it is.

Okay.  I'd better fix this up before I forget all this.