From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21189 invoked by alias); 28 Oct 2003 18:17:41 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 21169 invoked from network); 28 Oct 2003 18:17:37 -0000 Received: from unknown (HELO zenia.home) (12.223.225.216) by sources.redhat.com with SMTP; 28 Oct 2003 18:17:37 -0000 Received: by zenia.home (Postfix, from userid 5433) id 7B9EF20766; Tue, 28 Oct 2003 13:16:41 -0500 (EST) To: Elena Zannoni Cc: Daniel Jacobowitz , "J. Johnston" , gdb-patches@sources.redhat.com Subject: Re: RFA: switch to printf_unfiltered in symfile.c References: <3F96CF9A.9080003@redhat.com> <20031028043039.GA27446@nevyn.them.org> <16286.38008.938675.454310@localhost.redhat.com> From: Jim Blandy Date: Tue, 28 Oct 2003 18:17:00 -0000 In-Reply-To: <16286.38008.938675.454310@localhost.redhat.com> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-10/txt/msg00815.txt.bz2 Elena Zannoni writes: > Daniel Jacobowitz writes: > > On Wed, Oct 22, 2003 at 02:42:34PM -0400, J. Johnston wrote: > > > The following patch switches over the majority of the printfs in symfile.c > > > to use printf_unfiltered. This fixes a problem whereby if you attach to a > > > process that has a lot of dynamic library references, you will get page > > > breaks as it displays loading symbols messages. > > > > > > I purposely left printf_filtered for info_ext_lang_command(), and > > > list_overlays_command() as I felt that a user may want to examine the > > > output and this should allow paging if necessary. > > > > > > Ok to commit? > > > > > > -- Jeff J. > > > > > > 2003-10-22 Jeff Johnston > > > > > > * symfile.c (symbol_file_add_with_addrs_or_offsets): Switch to use > > > printf_unfiltered instead of printf_filtered for output messages. > > > (add_symbol_file_command): Ditto. > > > (reread_symbols): Ditto. > > > (overlay_auto_command): Ditto. > > > (overlay_manual_command): Ditto. > > > (overlay_off_command): Ditto. > > > > Do any of our symtab maintainers have a comment on this patch? I > > vaguely remember that you agreed with it on gdb@, Jim? > > > > I'll approve it. I did some digging in the old Cygnus repository that > dates back to 1991, and the code was already like that back then. So > there really seem to be no rationale other than letting the user read > the messages. Maybe back then nobody imagined that there would be more > than a screen of output. Yes, I did mean to approve it as part of the discussion on gdb@.