From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9925 invoked by alias); 20 Jan 2004 19:56:39 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9909 invoked from network); 20 Jan 2004 19:56:37 -0000 Received: from unknown (HELO zenia.home) (12.223.225.216) by sources.redhat.com with SMTP; 20 Jan 2004 19:56:37 -0000 Received: by zenia.home (Postfix, from userid 5433) id E8D71208E7; Tue, 20 Jan 2004 14:55:40 -0500 (EST) To: Ulrich Weigand Cc: gdb-patches@sources.redhat.com, uweigand@de.ibm.com Subject: Re: [PATCH] S/390 port modernization - revised 4/4 References: <200401191931.UAA02622@faui1d.informatik.uni-erlangen.de> From: Jim Blandy Date: Tue, 20 Jan 2004 19:56:00 -0000 In-Reply-To: <200401191931.UAA02622@faui1d.informatik.uni-erlangen.de> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2004-01/txt/msg00562.txt.bz2 Assuming these four revised patches introduce no new ARI hits, they're approved. There is only one change I'd like to see, to the log entries. > ChangeLog: > ... > (op_*, op1_*, op2_* enums): Add several new opcodes. It's best never to use wildcards in ChangeLog entries. People don't read the ChangeLog from start to end (or end to start); they search for entries that refer to the item they're trying to understand. I think the ChangeLog entry should specifically list those op* values that were added: (op1_ag, op1_ay, op1_brasl, op1_brc, op1_brcl, op1_lay, op1_lg) (op1_lmy, op1_ly, op1_sg, op1_stmy, op1_sty, op1_sy, op_a) (op_agr, op_bas, op_bc, op_bcr, op_sgr, op_sr): New opcodes. I see there were none removed, or significantly changed. If this is inconvenient for you, I can make the change after your patch is committed.