From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14674 invoked by alias); 31 Jul 2004 04:16:31 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 14648 invoked from network); 31 Jul 2004 04:16:27 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 31 Jul 2004 04:16:27 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i6V4GRe1031013 for ; Sat, 31 Jul 2004 00:16:27 -0400 Received: from zenia.home.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i6V4GPa30023; Sat, 31 Jul 2004 00:16:26 -0400 To: Bryce McKinlay Cc: gdb-patches@sources.redhat.com Subject: Re: Patch: Handle relative paths in .debug_line References: <41004E5D.5020403@redhat.com> <4101A540.5050208@redhat.com> <4109641D.7090301@redhat.com> From: Jim Blandy Date: Sat, 31 Jul 2004 04:16:00 -0000 In-Reply-To: <4109641D.7090301@redhat.com> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2004-07/txt/msg00533.txt.bz2 Bryce McKinlay writes: > Jim Blandy wrote: > >Almost --- dwarf2_start_subfile still passes comp_dir to concat > >without checking whether it's NULL. > > > Fixed in the following patch. OK? Looks better! You've done before-and-after runs of the test suite, right? If there are no regressions there, please feel free to commit. Are there any tests currently in the test suite that catch this bug?