From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3088 invoked by alias); 5 May 2006 19:40:07 -0000 Received: (qmail 3077 invoked by uid 22791); 5 May 2006 19:40:06 -0000 X-Spam-Check-By: sourceware.org Received: from intranet.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.6) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 05 May 2006 19:40:05 +0000 Received: (qmail 11112 invoked from network); 5 May 2006 19:40:03 -0000 Received: from unknown (HELO localhost) (jimb@127.0.0.2) by mail.codesourcery.com with ESMTPA; 5 May 2006 19:40:03 -0000 To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: [RFC/RFA] Cleaner handling of character entities ? References: <20060505182351.GK1109@adacore.com> <20060505182852.GL31029@nevyn.them.org> <20060505190625.GA1042@adacore.com> From: Jim Blandy Date: Fri, 05 May 2006 19:40:00 -0000 In-Reply-To: <20060505190625.GA1042@adacore.com> (Joel Brobecker's message of "Fri, 5 May 2006 12:06:25 -0700") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-05/txt/msg00088.txt.bz2 Joel Brobecker writes: > We would be left with: > > * dwarf2read.c (read_base_type): Set code to TYPE_CODE_CHAR > for char and unsigned char types of Ada compilation units. > * ada-lang.c (ada_is_character_type): Always return true if > the type code is TYPE_CODE_CHAR. > > Would that be OK? Yeah, I think that sounds like the right thing.