Re: [PATCH] add-symbol-file-from-memory command

Jim Blandy
2004-04-08T22:13:01Z

Roland McGrath <roland@redhat.com> writes:
> I updated my tree and made a new diff for add-symbol-file-from-memory,
> though there were no conflicts to resolve so it's not materially different
> >From the last version of this patch I posted. It still works with today's
> gdb. Several people have looked at this code before. It just needs
> authoritative approval to go in. If anyone has any reservations, I haven't
> heard them articulated. As I've mentioned before, the new command itself
> is not the motivation for the new function. It's the final piece of
> necessary infrastructure for vsyscall DSO support for Linux targets.
> (After this, the only thing needed is the glue to check for AT_SYSINFO at
> the right time.)

This looks fine. Two suggestions:

- Would it work to completely replace
symbol_file_add_with_addrs_or_offsets's 'name' argument with the
abfd argument, and then just use bfd_get_filename? It looks to me
like the only affect would be that the tilde-expanded, path-searched
filename would appear in messages, which seems like a good thing.

- Since the command isn't something that ordinary users are really
going to want themselves, but is more for the benefit of GDB
developers, should be a 'maint' subcommand?