From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14278 invoked by alias); 5 Dec 2003 21:54:29 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 14264 invoked from network); 5 Dec 2003 21:54:28 -0000 Received: from unknown (HELO zenia.home) (12.223.225.216) by sources.redhat.com with SMTP; 5 Dec 2003 21:54:28 -0000 Received: by zenia.home (Postfix, from userid 5433) id 49DEC20766; Fri, 5 Dec 2003 16:52:45 -0500 (EST) To: Andrew Cagney Cc: Ulrich Weigand , gdb-patches@sources.redhat.com, uweigand@de.ibm.com Subject: Re: [PATCH] S/390 port modernization 3/4 References: <200312042007.VAA07717@faui1d.informatik.uni-erlangen.de> <3FD09F38.4010807@gnu.org> From: Jim Blandy Date: Fri, 05 Dec 2003 21:54:00 -0000 In-Reply-To: <3FD09F38.4010807@gnu.org> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-12/txt/msg00228.txt.bz2 Andrew Cagney writes: > Ulrich, > > two FYIs > > ! else > > ! abort (); > > } > > GDB doesn't call abort (well ok, there's one call :-) Instead for > cases like this GDB should call internal_error. > > > ! case RETURN_VALUE_STRUCT_CONVENTION: > > ! error ("Cannot set function return value."); > > ! break; > > If this happens, GDB's shot itself in the foot so might as well call > internal_error here as well. > > Jim, since you're handling this, can I assume that you'll clean up any > nuences that the ARI identifies (as I did for the last round of s390 > patches). It will save Ulrich the need of respining what are basicly > correct patches. In general, sure. But in this case it seems like Ulrich is already respinning things pretty quickly.