From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19658 invoked by alias); 19 Apr 2004 12:42:41 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19590 invoked from network); 19 Apr 2004 12:42:40 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 19 Apr 2004 12:42:40 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i3JCgeJW031757 for ; Mon, 19 Apr 2004 08:42:40 -0400 Received: from zenia.home.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i3J6a1j31135; Mon, 19 Apr 2004 02:36:02 -0400 To: Daniel Jacobowitz CC: gdb-patches@sources.redhat.com Subject: Re: [RFA/dwarf] Eliminate dwarf2_tmp_obstack References: <20040419031744.GA22586@nevyn.them.org> From: Jim Blandy Date: Mon, 19 Apr 2004 12:42:00 -0000 In-Reply-To: <20040419031744.GA22586@nevyn.them.org> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2004-04/txt/msg00416.txt.bz2 Daniel Jacobowitz writes: > dwarf2_tmp_obstack serves as a general purpose dumping ground. After my > previous patches, there are only two things left on it: the linked list we > use to fudge GCC 2.95 line number tables (some day soon I think this hack > should go away; it was primarily for the benefit of the testsuite, and was > fixed at least as of GCC 3.1), and the block structures created in > read_attribute_value. > > Both of these are clearly associated with a particular compilation unit. > If we put them on the comp_unit_obstack, then we don't have any need for > the global obstack any more. > > Since my following patches change the lifetimes of individual CUs, I felt > this was a worthwhile cleanup. OK? You need to fix up the comments above free_stack_comp_unit; it's no longer "only used during partial symbol processing". I'd like free_stack_comp_unit renamed to free_comp_unit_obstack, so that when I search for comp_unit_obstack, I'll also run into the calls to make_cleanup that will free it. Otherwise, looks good.