From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-36148-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 23083 invoked by alias); 5 Oct 2004 16:41:14 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 23075 invoked from network); 5 Oct 2004 16:41:13 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sourceware.org with SMTP; 5 Oct 2004 16:41:13 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.11/8.12.10) with ESMTP id i95GfD56006688
	for <gdb-patches@sources.redhat.com>; Tue, 5 Oct 2004 12:41:13 -0400
Received: from zenia.home.redhat.com (sebastian-int.corp.redhat.com [172.16.52.221])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i95GfBr21457;
	Tue, 5 Oct 2004 12:41:12 -0400
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA] dwarf2read.c: Use make_function_type instead of lookup_function_type
References: <20041005162205.GA31478@cygbert.vinschen.de>
From: Jim Blandy <jimb@redhat.com>
Date: Tue, 05 Oct 2004 16:41:00 -0000
In-Reply-To: <20041005162205.GA31478@cygbert.vinschen.de>
Message-ID: <vt2hdp915js.fsf@zenia.home>
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2004-10/txt/msg00087.txt.bz2

Corinna Vinschen <vinschen@redhat.com> writes:
> the below patch uses make_function_type instead of lookup_function_type
> in read_subroutine_type.  The reason is that it's important that `ftype'
> is a new type structure for each function and so it shouldn't get reused
> by other function types.  The comment for lookup_function_type indicates
> that it's made to do exactly that, reusing already existing function
> types as they fit.  That's not implemented so far, but it might happen
> at one point, so I suggest to switch to make_function_type in
> read_subroutine_type before something weird happens.
> 
> Ok to check in?
> 
> 
> Corinna
> 
> 	* dwarf2read.c (read_subroutine_type): Call make_function_type
> 	instead of lookup_function_type.

This looks fine.  Thanks!