From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18597 invoked by alias); 7 Apr 2005 05:00:30 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18358 invoked from network); 7 Apr 2005 05:00:15 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 7 Apr 2005 05:00:15 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j3750EOj028331 for ; Thu, 7 Apr 2005 01:00:14 -0400 Received: from zenia.home.redhat.com (sebastian-int.corp.redhat.com [172.16.52.221]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j3750DO06497; Thu, 7 Apr 2005 01:00:13 -0400 To: Mark Kettenis Cc: drow@false.org, gdb-patches@sources.redhat.com Subject: Re: RFC: Add 'double' member to 64-bit vector register type References: <20050319153709.GA4659@nevyn.them.org> <20050320023307.GA12519@nevyn.them.org> <200503201114.j2KBE12K023890@elgar.sibelius.xs4all.nl> <200504060708.j3678o1G030940@elgar.sibelius.xs4all.nl> From: Jim Blandy Date: Thu, 07 Apr 2005 05:00:00 -0000 In-Reply-To: <200504060708.j3678o1G030940@elgar.sibelius.xs4all.nl> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2005-04/txt/msg00064.txt.bz2 Mark Kettenis writes: > From: Jim Blandy > Date: 05 Apr 2005 11:55:43 -0500 > > Mark Kettenis writes: > > Date: Sat, 19 Mar 2005 21:33:07 -0500 > > From: Daniel Jacobowitz > > > > On Sat, Mar 19, 2005 at 04:13:12PM -0500, Jim Blandy wrote: > > > Well, that brings up the other thought --- since the set of types > > > useful to include in a vector register really depends on the > > > architecture, wouldn't it be better to just export the convenience > > > functions for constructing these types from gdbtypes.c and then let > > > architectures build ones that actually suit their needs? > > > > My inclination is "yes". Anybody else? > > > > I agree. > > Getting back to this... > > Here's a patch to move the IA-32 vector types out of gdbtypes.h. The > PowerPC Altivec and SPE types are a little more work, since they > need to be per-architecture, so I'll leave that to a separate patch. > > How does this look? > > Looks fine to me, except for one nit: can you remove the "excessive" > spacing (one blank line between functions is more than enough, > especially since all the new stuff logically belongs together). Done, and committed. Thanks!