From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24249 invoked by alias); 28 Jul 2004 19:05:36 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24237 invoked from network); 28 Jul 2004 19:05:36 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 28 Jul 2004 19:05:36 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i6SJ5Ze1026703 for ; Wed, 28 Jul 2004 15:05:36 -0400 Received: from zenia.home.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i6SJ5Xa22846; Wed, 28 Jul 2004 15:05:34 -0400 To: David Lecomber Cc: Daniel Jacobowitz , patches Subject: Re: Dwarf2 Producer info References: <1090362598.21483.108.camel@cpc4-oxfd5-5-0-cust12.oxfd.cable.ntl.com> <20040720231756.GA8250@nevyn.them.org> <1090367767.21483.120.camel@cpc4-oxfd5-5-0-cust12.oxfd.cable.ntl.com> <20040721000823.GA10146@nevyn.them.org> <1090394885.21483.134.camel@cpc4-oxfd5-5-0-cust12.oxfd.cable.ntl.com> From: Jim Blandy Date: Wed, 28 Jul 2004 19:05:00 -0000 In-Reply-To: <1090394885.21483.134.camel@cpc4-oxfd5-5-0-cust12.oxfd.cable.ntl.com> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2004-07/txt/msg00428.txt.bz2 David Lecomber writes: > Fine by me -- in fact, even the null setting isn't needed now I've found > the bit that ensures the cu is cleared during allocation (do you > agree?). Looks fine --- but you need a ChangeLog entry for the change to 'struct dwarf2_cu', as well as the change to read_file_scope. With that change, this is okay.