From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12614 invoked by alias); 15 Mar 2005 21:08:34 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12317 invoked from network); 15 Mar 2005 21:08:28 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 15 Mar 2005 21:08:28 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j2FL8SsH010662 for ; Tue, 15 Mar 2005 16:08:28 -0500 Received: from zenia.home.redhat.com (sebastian-int.corp.redhat.com [172.16.52.221]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j2FL8QY05706; Tue, 15 Mar 2005 16:08:27 -0500 To: gdb-patches@sources.redhat.com Subject: RFC: sim: don't use -Wuninitialized without -O From: Jim Blandy Date: Tue, 15 Mar 2005 21:08:00 -0000 Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2005-03/txt/msg00207.txt.bz2 I committed a similar patch for GDB a few days ago; this one is for the simulators. I think I've avoided using '==' in this one. :) Diffs to generated files omitted. sim/common/ChangeLog: 2005-02-28 Jim Blandy * aclocal.m4 (SIM_AC_OPTION_WARNINGS): Don't include -Wuninitialized in the default list of build warnings if CFLAGS is set, and doesn't include -O. (Using -Wuninitialized without optimization produces a warning, which interferes with compilation with -Werror.) sim/ChangeLog: 2005-02-28 Jim Blandy * d10v/configure.ac, igen/configure.ac, m68hc11/configure.ac, mips/configure.ac, mn10300/configure.ac, v850/configure.ac: Regenerated, after change to common/aclocal.m4. Index: sim/common/aclocal.m4 =================================================================== RCS file: /cvs/src/src/sim/common/aclocal.m4,v retrieving revision 1.9 diff -c -p -r1.9 aclocal.m4 *** sim/common/aclocal.m4 12 Jan 2005 16:23:13 -0000 1.9 --- sim/common/aclocal.m4 28 Feb 2005 20:38:02 -0000 *************** AC_DEFUN(SIM_AC_OPTION_WARNINGS, *** 790,796 **** # NOTE: If you add to this list, remember to update # gdb/doc/gdbint.texinfo. build_warnings="-Wimplicit -Wreturn-type -Wcomment -Wtrigraphs \ ! -Wformat -Wparentheses -Wpointer-arith -Wuninitialized" # Up for debate: -Wswitch -Wcomment -trigraphs -Wtrigraphs # -Wunused-function -Wunused-label -Wunused-variable -Wunused-value # -Wchar-subscripts -Wtraditional -Wshadow -Wcast-qual --- 790,807 ---- # NOTE: If you add to this list, remember to update # gdb/doc/gdbint.texinfo. build_warnings="-Wimplicit -Wreturn-type -Wcomment -Wtrigraphs \ ! -Wformat -Wparentheses -Wpointer-arith" ! # GCC supports -Wuninitialized only with -O or -On, n != 0. ! if test x${CFLAGS+set} = xset; then ! case "${CFLAGS}" in ! *"-O0"* ) ;; ! *"-O"* ) ! build_warnings="${build_warnings} -Wuninitialized" ! ;; ! esac ! else ! build_warnings="${build_warnings} -Wuninitialized" ! fi # Up for debate: -Wswitch -Wcomment -trigraphs -Wtrigraphs # -Wunused-function -Wunused-label -Wunused-variable -Wunused-value # -Wchar-subscripts -Wtraditional -Wshadow -Wcast-qual