From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-41091-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 27529 invoked by alias); 12 Oct 2005 18:21:40 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 27457 invoked by uid 22791); 12 Oct 2005 18:21:38 -0000
Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31)
    by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Wed, 12 Oct 2005 18:21:38 +0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j9CILaYu032517
	for <gdb-patches@sourceware.org>; Wed, 12 Oct 2005 14:21:36 -0400
Received: from devserv.devel.redhat.com (devserv.devel.redhat.com [172.16.58.1])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j9CILaV26798;
	Wed, 12 Oct 2005 14:21:36 -0400
Received: from theseus.home..redhat.com (vpn26-6.sfbay.redhat.com [172.16.26.6])
	by devserv.devel.redhat.com (8.12.11/8.12.11) with ESMTP id j9CILYnZ014757;
	Wed, 12 Oct 2005 14:21:35 -0400
To: gdb-patches@sourceware.org
Subject: Re: RFA: contribute Renesas M32C sim
References: <m3zmpl5a7a.fsf@alligator.red-bean.com>
	<20051009201500.GD7107@nevyn.them.org>
From: Jim Blandy <jimb@redhat.com>
Date: Wed, 12 Oct 2005 18:21:00 -0000
In-Reply-To: <20051009201500.GD7107@nevyn.them.org> (Daniel Jacobowitz's
 message of "Sun, 9 Oct 2005 16:15:00 -0400")
Message-ID: <vt2fyr6sij6.fsf@theseus.home.>
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2005-10/txt/msg00113.txt.bz2

Daniel Jacobowitz <drow@false.org> writes:
> The most glaring omission is copyright notices.  Not a single one. 
> Pretty much every file should have one.  I assume the intention is to
> assign this contribution to the FSF.

My face is red.  Of course there should be copyright notices.

> There seem to be a lot of too-long lines.

I'll address those.

>> + void
>> + prefix (src_allowed, dest_allowed, index_bytewidth)
>> + {
>> + }
>
> And what's that for?

I don't know.  I thought it was some sort of annotation for opc2c to
consume, but that doesn't seem to be so.  I'll find out.