From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27208 invoked by alias); 7 Nov 2002 20:36:58 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27200 invoked from network); 7 Nov 2002 20:36:57 -0000 Received: from unknown (HELO zenia.red-bean.com) (66.244.67.22) by sources.redhat.com with SMTP; 7 Nov 2002 20:36:57 -0000 Received: (from jimb@localhost) by zenia.red-bean.com (8.11.6/8.11.6) id gA7KLqt30710; Thu, 7 Nov 2002 15:21:52 -0500 To: Adam Fedor Cc: Elena Zannoni , Klee Dienes , Michael Snyder , gdb-patches@sources.redhat.com Subject: Re: [PATCH] Redefine skip_quoted References: <95706CBA-DFBC-11D6-A1B6-00039396EEB8@apple.com> <3DAF2C71.6030908@doc.com> <15792.33251.884402.152637@localhost.redhat.com> <3DB09113.9070205@doc.com> From: Jim Blandy Date: Thu, 07 Nov 2002 12:36:00 -0000 In-Reply-To: <3DB09113.9070205@doc.com> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2.90 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-11/txt/msg00194.txt.bz2 Adam Fedor writes: > > > > > > Well, really the use of skip_quoted for ObjC (in a patch > > that I haven't > submitted yet), really has more to do with > > handling the canonical form > of an Objective-C method symbol > > (e.g. -[MyObject myMethod:arg2:]) that > comes from > > objc-lang.c. Most of the breakpoint cases that a user would > enter > > are handled elsewhere (in a patch that I also haven't submitted). > > > I have to agree with Jim here, I think we should wait on the > > parts you > > haven't submitted before deciding on this one. Could you just have > > added the chars you need to the gdb_completer_word_break_characters > > variable? > > No. It involves removing characters. Another option would be to define > a new function, say skip_objc_quoted, just for objc which would be > similar to skip_quoted. How about that? So, the change would become local to the Objective-C code, right? If it doesn't hurt the functionality you're trying to provide, that certainly sounds better to me, at least.