From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28655 invoked by alias); 1 Apr 2004 20:58:25 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28633 invoked from network); 1 Apr 2004 20:58:23 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 1 Apr 2004 20:58:23 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i31KwNjj003141 for ; Thu, 1 Apr 2004 15:58:23 -0500 Received: from zenia.home.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i31KwLj13322; Thu, 1 Apr 2004 15:58:22 -0500 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com, ezannoni@redhat.com Subject: Re: [rfa/dwarf] Use objfile_data mechanism for per-objfile data References: <20040401171557.GA17948@nevyn.them.org> From: Jim Blandy Date: Thu, 01 Apr 2004 20:58:00 -0000 In-Reply-To: <20040401171557.GA17948@nevyn.them.org> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2004-04/txt/msg00038.txt.bz2 Wonderful! So it turns out 'struct dwarf2_pinfo' has only one real member, huh? :) I have to say, 'dwarf2_per_objfile_data', 'struct dwarf2_per_objfile_data', and 'dwarf2_per_objfile' are not my favorite cluster of names. It took me a few passes to get it straight. (Yes, I should have gotten more sleep, but I suspect there are others who work under the same conditions...) How about: - 'dwarf2_objfile_data_key' for the 'struct objfile_data', and - 'struct dwarf2_objfile' and 'dwarf2_objfile' for the actual per-objfile datatype and the global pointer to the current instance? (Is that any better? I think suffixes like "_data" really only belong on things whose type is unspecified at the point where the name appears, like 'void *' pointers, or objects related to them. I mean, everything is "data"; if you're going to give something a generic-sounding name, that should be because you're emphasizing the genericness of it.) The lower-case implicit-parameter macros bug me. But I assume they're going away soon, and upper-casing them would make the patch huge, right?