Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: RFA: gdb.base/charset.exp: tighten regexp for ^C
Date: Fri, 04 Jun 2004 05:31:00 -0000	[thread overview]
Message-ID: <vt2ekovlwq2.fsf@zenia.home> (raw)


The problem with the regexp for the clause that sends ^C is that it
matches a prefix of the correct output.  If expect sees GDB's output
arrive in small chunks, then that clause can trigger even when GDB is
behaving correctly.  This happens on AIX.

I didn't see any discussion in the archives of the sort of situations
this clause was meant to handle.  A different approach might be for
the timeout clause to send a ^C the first time around, and then
actually fail the second time around.  Then the situation the clause
the patch tweaks was meant to handle (now there's a nice noun clause)
will be caught by the ordinary $gdb_prompt case.

2004-06-03  Jim Blandy  <jimb@redhat.com>

	* gdb.base/charset.exp: Only send a control-C if we see a new
	prompt and incomplete command.

Index: gdb/testsuite/gdb.base/charset.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/charset.exp,v
retrieving revision 1.3
diff -c -p -r1.3 charset.exp
*** gdb/testsuite/gdb.base/charset.exp	26 Feb 2004 17:23:23 -0000	1.3
--- gdb/testsuite/gdb.base/charset.exp	4 Jun 2004 04:20:01 -0000
*************** gdb_expect {
*** 140,146 ****
  	# We got some output that ended with a regular prompt
          fail "get valid character sets"
      }
!     -re "^set charset.*$" {
  	# We got some other output, send a cntrl-c to gdb to get us back
          # to the prompt.
  	send_gdb "\003"
--- 140,146 ----
  	# We got some output that ended with a regular prompt
          fail "get valid character sets"
      }
!     -re ".*$gdb_prompt set charset.*$" {
  	# We got some other output, send a cntrl-c to gdb to get us back
          # to the prompt.
  	send_gdb "\003"


             reply	other threads:[~2004-06-04  5:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-04  5:31 Jim Blandy [this message]
2004-06-04 21:55 ` Jim Blandy
2004-06-17 21:11 ` Jim Blandy
2004-06-17 21:34 Michael Elizabeth Chastain
2004-06-17 22:15 ` Jim Blandy
2004-06-18 23:13 ` Jim Blandy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vt2ekovlwq2.fsf@zenia.home \
    --to=jimb@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox