From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25119 invoked by alias); 8 Oct 2003 19:32:16 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25096 invoked from network); 8 Oct 2003 19:32:14 -0000 Received: from unknown (HELO zenia.home) (12.223.225.216) by sources.redhat.com with SMTP; 8 Oct 2003 19:32:14 -0000 Received: by zenia.home (Postfix, from userid 5433) id D442C20766; Wed, 8 Oct 2003 14:30:48 -0500 (EST) To: gdb-patches@sources.redhat.com Subject: Re: RFC: Use program_transform_name correctly References: <20031007225305.GA13082@nevyn.them.org> <20031007235921.8FB0B158F81@kanga.canids.net> <20031008010510.GA15693@nevyn.them.org> From: Jim Blandy Date: Wed, 08 Oct 2003 19:32:00 -0000 In-Reply-To: <20031008010510.GA15693@nevyn.them.org> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-10/txt/msg00247.txt.bz2 Could someone proofread this boring patch very carefully? gdb/Makefile.in: 2003-10-08 Jim Blandy * Makefile.in (CC_FOR_TARGET, CXX_FOR_TARGET, install-only): Use program_transform_name properly. * nlm/Makefile.in (CC_FOR_TARGET, NLMCONV_FOR_TARGET): Same. gdb/gdbserver/Makefile.in: 2003-10-08 Jim Blandy * Makefile.in (install-only, uninstall): Use program_transform_name properly. gdb/testsuite/Makefile.in: 2003-10-08 Jim Blandy * Makefile.in (RUNTEST_FOR_TARGET): Use program_transform_name properly. Index: gdb/Makefile.in =================================================================== RCS file: /cvs/src/src/gdb/Makefile.in,v retrieving revision 1.454 diff -c -r1.454 Makefile.in *** gdb/Makefile.in 8 Oct 2003 02:41:49 -0000 1.454 --- gdb/Makefile.in 8 Oct 2003 19:22:39 -0000 *************** *** 465,471 **** if [ "$(host_canonical)" = "$(target_canonical)" ] ; then \ echo $(CC); \ else \ ! t='$(program_transform_name)'; echo gcc | sed -e '' $$t; \ fi; \ fi` --- 465,471 ---- if [ "$(host_canonical)" = "$(target_canonical)" ] ; then \ echo $(CC); \ else \ ! t='$(program_transform_name)'; echo gcc | sed -e $$t; \ fi; \ fi` *************** *** 481,487 **** if [ "$(host_canonical)" = "$(target_canonical)" ] ; then \ echo $(CXX); \ else \ ! t='$(program_transform_name)'; echo gcc | sed -e '' $$t; \ fi; \ fi` --- 481,487 ---- if [ "$(host_canonical)" = "$(target_canonical)" ] ; then \ echo $(CXX); \ else \ ! t='$(program_transform_name)'; echo gcc | sed -e $$t; \ fi; \ fi` *************** *** 963,969 **** install: all install-only install-only: $(CONFIG_INSTALL) transformed_name=`t='$(program_transform_name)'; \ ! echo gdb | sed -e "$$t"` ; \ if test "x$$transformed_name" = x; then \ transformed_name=gdb ; \ else \ --- 963,969 ---- install: all install-only install-only: $(CONFIG_INSTALL) transformed_name=`t='$(program_transform_name)'; \ ! echo gdb | sed -e $$t` ; \ if test "x$$transformed_name" = x; then \ transformed_name=gdb ; \ else \ Index: gdb/gdbserver/Makefile.in =================================================================== RCS file: /cvs/src/src/gdb/gdbserver/Makefile.in,v retrieving revision 1.24 diff -c -r1.24 Makefile.in *** gdb/gdbserver/Makefile.in 8 Aug 2003 17:30:36 -0000 1.24 --- gdb/gdbserver/Makefile.in 8 Oct 2003 19:22:40 -0000 *************** *** 149,155 **** # install-only is intended to address that need. install: all install-only install-only: ! n=`echo gdbserver | sed '$(program_transform_name)'`; \ if [ x$$n = x ]; then n=gdbserver; else true; fi; \ $(SHELL) $(srcdir)/../../mkinstalldirs $(DESTDIR)$(bindir); \ $(INSTALL_PROGRAM) gdbserver $(DESTDIR)$(bindir)/$$n; \ --- 149,155 ---- # install-only is intended to address that need. install: all install-only install-only: ! n=`t='$(program_transform_name)'; echo gdbserver | sed $$t`; \ if [ x$$n = x ]; then n=gdbserver; else true; fi; \ $(SHELL) $(srcdir)/../../mkinstalldirs $(DESTDIR)$(bindir); \ $(INSTALL_PROGRAM) gdbserver $(DESTDIR)$(bindir)/$$n; \ *************** *** 157,163 **** $(INSTALL_DATA) $(srcdir)/gdbserver.1 $(DESTDIR)$(man1dir)/$$n.1 uninstall: force ! n=`echo gdbserver | sed '$(program_transform_name)'`; \ if [ x$$n = x ]; then n=gdbserver; else true; fi; \ rm -f $(bindir)/$$n $(DESTDIR)$(man1dir)/$$n.1 --- 157,163 ---- $(INSTALL_DATA) $(srcdir)/gdbserver.1 $(DESTDIR)$(man1dir)/$$n.1 uninstall: force ! n=`t='$(program_transform_name)'; echo gdbserver | sed $$t`; \ if [ x$$n = x ]; then n=gdbserver; else true; fi; \ rm -f $(bindir)/$$n $(DESTDIR)$(man1dir)/$$n.1 Index: gdb/nlm/Makefile.in =================================================================== RCS file: /cvs/src/src/gdb/nlm/Makefile.in,v retrieving revision 1.2 diff -c -r1.2 Makefile.in *** gdb/nlm/Makefile.in 6 Mar 2001 08:21:46 -0000 1.2 --- gdb/nlm/Makefile.in 8 Oct 2003 19:22:40 -0000 *************** *** 55,68 **** if [ -f ../../gcc/xgcc ] ; then \ echo ../../gcc/xgcc -B../../gcc/; \ else \ ! t='$(program_transform_name)'; echo gcc | sed -e '' $$t; \ fi` NLMCONV_FOR_TARGET = ` \ if [ -f ../../binutils/nlmconv ] ; then \ echo ../../binutils/nlmconv; \ else \ ! t='$(program_transform_name)'; echo nlmconv | sed -e '' $$t; \ fi` # All the includes used for CFLAGS and for lint. --- 55,68 ---- if [ -f ../../gcc/xgcc ] ; then \ echo ../../gcc/xgcc -B../../gcc/; \ else \ ! t='$(program_transform_name)'; echo gcc | sed -e $$t; \ fi` NLMCONV_FOR_TARGET = ` \ if [ -f ../../binutils/nlmconv ] ; then \ echo ../../binutils/nlmconv; \ else \ ! t='$(program_transform_name)'; echo nlmconv | sed -e $$t; \ fi` # All the includes used for CFLAGS and for lint. Index: gdb/testsuite/Makefile.in =================================================================== RCS file: /cvs/src/src/gdb/testsuite/Makefile.in,v retrieving revision 1.8 diff -c -r1.8 Makefile.in *** gdb/testsuite/Makefile.in 23 Aug 2003 03:55:58 -0000 1.8 --- gdb/testsuite/Makefile.in 8 Oct 2003 19:22:48 -0000 *************** *** 53,59 **** if [ "$(host_canonical)" = "$(target_canonical)" ]; then \ echo runtest; \ else \ ! t='$(program_transform_name)'; echo runtest | sed -e '' $$t; \ fi; \ fi` --- 53,59 ---- if [ "$(host_canonical)" = "$(target_canonical)" ]; then \ echo runtest; \ else \ ! t='$(program_transform_name)'; echo runtest | sed -e $$t; \ fi; \ fi`