From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-20216-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 16177 invoked by alias); 18 Nov 2002 21:18:51 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 16154 invoked from network); 18 Nov 2002 21:18:48 -0000
Received: from unknown (HELO zenia.red-bean.com) (66.244.67.22)
  by sources.redhat.com with SMTP; 18 Nov 2002 21:18:48 -0000
Received: (from jimb@localhost)
	by zenia.red-bean.com (8.11.6/8.11.6) id gAIL2K424053;
	Mon, 18 Nov 2002 16:02:20 -0500
To: Klee Dienes <klee@apple.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Handle stack underflow in dbxread.c
References: <3908551A-FB2A-11D6-84AF-00039396EEB8@apple.com>
From: Jim Blandy <jimb@redhat.com>
Date: Mon, 18 Nov 2002 13:18:00 -0000
In-Reply-To: <3908551A-FB2A-11D6-84AF-00039396EEB8@apple.com>
Message-ID: <vt2bs4mlhgj.fsf@zenia.red-bean.com>
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2.92
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2002-11/txt/msg00472.txt.bz2


Klee Dienes <klee@apple.com> writes:
> On Monday, November 18, 2002, at 12:40 PM, Jim Blandy wrote:
> 
> >
> > Okay, that looks like a good change to me --- please commit it.
> >
> > But rather than making pop_context a hairy macro, could you make it a
> > function in buildsym.c, right after push_context?
> 
> 
> Gladly.  Committed the following:

Great!

By the way, buildsym.o now depends on gdb_assert.h.  Could you add the
dependency to Makefile.in?