From: Jim Blandy <jimb@redhat.com>
To: Ulrich Weigand <weigand@i1.informatik.uni-erlangen.de>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Fix invalid use of va_list
Date: Tue, 30 Mar 2004 15:44:00 -0000 [thread overview]
Message-ID: <vt2brmeibma.fsf@zenia.home> (raw)
In-Reply-To: <200403301336.PAA17124@faui1d.informatik.uni-erlangen.de>
Looks good (obvious). This is not a legally significant change, so
I'll just commit it.
Thanks!
Ulrich Weigand <weigand@i1.informatik.uni-erlangen.de> writes:
> Hello,
>
> gdb crashes on s390 when the user answers a (y or n) question with
> something else. This is caused by the 'query' function reusing a
> va_list variable initialized only once multiple times.
>
> This is not allowed according to the C standard (C99 7.15.3), and
> in fact doesn't work on platforms that define va_list as an array
> type.
>
> The patch below changes query to reinitialize the va_list variable
> with va_start before each use.
>
> Tested on s390-ibm-linux.
>
> ChangeLog:
>
> * utils.c (query): Do not use a va_list variable multiple times.
prev parent reply other threads:[~2004-03-30 15:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-30 13:36 Ulrich Weigand
2004-03-30 15:44 ` Jim Blandy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vt2brmeibma.fsf@zenia.home \
--to=jimb@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=weigand@i1.informatik.uni-erlangen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox