From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-32326-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 25938 invoked by alias); 16 Apr 2004 04:24:25 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 25911 invoked from network); 16 Apr 2004 04:24:23 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sources.redhat.com with SMTP; 16 Apr 2004 04:24:23 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i3G4OMJW020899
	for <gdb-patches@sources.redhat.com>; Fri, 16 Apr 2004 00:24:22 -0400
Received: from zenia.home.redhat.com (porkchop.devel.redhat.com [172.16.58.2])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i3G4OKj31056;
	Fri, 16 Apr 2004 00:24:21 -0400
To: Joel Brobecker <brobecker@gnat.com>
Cc: Daniel Jacobowitz <drow@mvista.com>, Eli Zaretskii <eliz@elta.co.il>,
        gdb-patches@sources.redhat.com
Subject: Re: [RFC/dwarf-2] Add support for included files
References: <vt2d66jdbd8.fsf@zenia.home> <20040413052021.GA1173@gnat.com>
	<vt2isg25qfu.fsf@zenia.home> <20040415221338.GF1564@gnat.com>
From: Jim Blandy <jimb@redhat.com>
Date: Fri, 16 Apr 2004 04:24:00 -0000
In-Reply-To: <20040415221338.GF1564@gnat.com>
Message-ID: <vt2brls1rjy.fsf@zenia.home>
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2004-04/txt/msg00341.txt.bz2


Joel Brobecker <brobecker@gnat.com> writes:
> Using the approach you suggest (which I like): We need to define a
> couple of wrapper functions around start_subfile and record_line
> because their profile will not match the profile of our callbacks.
> We'll need 3 callbacks per case (3 for psymtabs, 3 for symtabs).
> We'll also have to use void* pointers if we want to make the context
> generic, which I would prefer to avoid. It's great for heavily reused
> code, but is this worth it for this function.

Maybe not.

If you add a comment above dwarf_decode_lines explaining how it's
called, and that PST determines whether we're building psymtabs or
symtabs, we'll call it even.

I just approved Daniel's mondo psymtab construction patch, so one of
you is going to get in the others' way.  Have fun.