Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@redhat.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa/dwarf] Support for attributes pointing to a different CU
Date: Mon, 04 Oct 2004 22:12:00 -0000	[thread overview]
Message-ID: <vt2brfi2l23.fsf@zenia.home> (raw)
In-Reply-To: <20041004004111.GD3234@nevyn.them.org>


This patch still avoids building the all_comp_units table if it never
finds a CU whose abbrev table suggests it might contain inter-CU
references.  What I was actually suggesting was building
all_comp_units for every objfile, unconditionally --- even for
objfiles with no inter-CU references, and which will thus never use
the table.

The win would be to remove the case of an absent all_comp_units table
from the code.  I want to keep the number of different cases one needs
to think about down where doing so doesn't provide a noticeable
performance hit.

On an 8000-CU objfile (what you estimated glibc compiled with
duplicate elimination would have), that would be a memory overhead of
160k, which doesn't seem bad.  It's true that that would be a separate
pass over the .debug_info section, but the latest patch will do two
passes anyway.

The quadratic bit in create_all_comp_units to recover the psymtabs
we'd already created wouldn't be needed any more.


  reply	other threads:[~2004-10-04 22:12 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-23  4:57 Daniel Jacobowitz
2004-09-23 22:19 ` Jim Blandy
2004-09-23 22:33   ` Daniel Jacobowitz
2004-09-24  0:34   ` Daniel Jacobowitz
2004-09-28 22:43     ` Jim Blandy
2004-09-28 22:51       ` Jim Blandy
2004-09-28 22:57       ` Jim Blandy
2004-10-04  0:41       ` Daniel Jacobowitz
2004-10-04 22:12         ` Jim Blandy [this message]
2004-10-04 23:35           ` Daniel Jacobowitz
2004-10-05  5:13             ` Jim Blandy
2004-09-28 23:07     ` Jim Blandy
2004-10-03 16:28       ` Daniel Jacobowitz
2004-09-29 17:52     ` Jim Blandy
2004-10-03 16:12       ` Daniel Jacobowitz
2004-10-04 21:17         ` Jim Blandy
2004-10-04 21:22           ` Daniel Jacobowitz
2004-10-05  5:07             ` Jim Blandy
2004-10-05 13:48               ` Daniel Jacobowitz
2004-10-05 16:13                 ` Jim Blandy
2004-10-05 16:11               ` Jim Blandy
2004-10-05 18:01                 ` Daniel Jacobowitz
2004-10-05 19:24                   ` Jim Blandy
2004-09-29 17:54     ` Jim Blandy
2004-09-29 19:53     ` Jim Blandy
2004-10-03 16:16       ` Daniel Jacobowitz
2004-09-29 20:19     ` Jim Blandy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vt2brfi2l23.fsf@zenia.home \
    --to=jimb@redhat.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox