Re: [commit]: Re: Enhanced language support for Modula-2

Gaius Mulley
2006-05-13T18:53:25Z

Daniel Jacobowitz <drow@false.org> writes:

> On Sat, May 13, 2006 at 04:49:49PM +0100, Gaius Mulley wrote:
> >
> > Hi,
> >
> > a small note to say that I've applied the Modula-2 enhancement patches
> > to the gdb cvs. Many thanks for all the guidance,
>
> Hi Gaius,
>
> Great to see this in. And I see you've been working on the ChangeLog
> entry. But it still needs a bit of work, so here's some pointers (some
> of these are from the GNU Coding Standards,
> http://www.gnu.org/prep/standards/, others are only implicit there but
> GDB tries to follow them carefully).

Hi,

many thanks for the pointers! I believe I've fixed all these now..

> Two spaces between name and email address in the header, please.

done

> Path names should be relative to the directory containing the
> ChangeLog, so just "m2-lang.h". Entries should start with a capital
> letter and end with a period (although sentence fragments are fine).

done

> We don't usually use explanatory sentences, just the actual changes; a
> bit strange, yes...

ok, removed lengthy descriptions concerning changes..

> The current version says:
>
> * gdb/dwarf2read.c: added ability to detect the language
> Modula-2
> and handle SET and CHAR types.
>
> Again about the pathname and the explanatory sentences, but also the
> wrapping; what's the stray newline for?

and removed typo..

regards,
Gaius