From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5803 invoked by alias); 10 May 2006 21:45:07 -0000 Received: (qmail 5773 invoked by uid 22791); 10 May 2006 21:45:06 -0000 X-Spam-Check-By: sourceware.org Received: from intranet.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.6) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 10 May 2006 21:45:05 +0000 Received: (qmail 12728 invoked from network); 10 May 2006 21:45:02 -0000 Received: from unknown (HELO localhost) (jimb@127.0.0.2) by mail.codesourcery.com with ESMTPA; 10 May 2006 21:45:02 -0000 To: Gaius Mulley Cc: "Eli Zaretskii" , gdb-patches@sources.redhat.com Subject: Re: Enhanced language support for Modula-2 References: <87psjc9yu3.fsf@glam.ac.uk> <87psius247.fsf@glam.ac.uk> <20060504153726.GA2396@nevyn.them.org> <8f2776cb0605041101u7d969e0eodde33866ac4abc41@mail.gmail.com> <874q00liyr.fsf@glam.ac.uk> <874pzyrf8l.fsf@glam.ac.uk> From: Jim Blandy Date: Wed, 10 May 2006 21:45:00 -0000 In-Reply-To: <874pzyrf8l.fsf@glam.ac.uk> (Gaius Mulley's message of "09 May 2006 23:43:38 +0100") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-05/txt/msg00204.txt.bz2 Gaius Mulley writes: > Jim Blandy writes: > >> Have you written ChangeLog entries for this? Follow the format the >> other entries use. >> >> In GDB code, each curly brace gets a line to itself. I see a few >> sharing a line with an 'if' or 'else' in m2-valprint.c and >> m2-typeprint.c. > > Hi Jim and Eli, > > sure ok, have done.. > >> Also, all GNU code should fit in eighty columns. > > ok, now fixed.. > >> I see some indentation problems in m2_val_print. If you're using GNU >> Emacs, just hit M-C-q before the function's opening brace, and it'll >> take care of it. > > yes I use emacs for most things.. but I hadn't come across this short > cut though.. very useful and I believe all is now fixed.. > > > > also enclosed is a proposed set of ChangeLog entries: Looks great! Two points to fix when you commit; don't bother re-posting the patch for review: - There's still an overly long line in m2-valprint.c, in the TYPE_CODE_STRUCT case. - Similarly, there's a separate ChangeLog for the doc directory; the entry for your change to gdb.texinfo should go in gdb/doc/ChangeLog, not gdb/ChangeLog. And generally, we put section names in parens after the filename, as we do for functions in C files. Like so: * gdb.texinfo (M2 Types): New section. I see that you have a copyright assignment on file. Do you have commit access to GDB? If not, we'll have to get you set up with that first. If you do, then make a commit to gdb/MAINTAINERS, adding yourself to "Write After Approval", with an appropriate ChangeLog entry. Then go ahead and commit the rest of the patch.