From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15456 invoked by alias); 9 Jun 2004 07:24:04 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15353 invoked from network); 9 Jun 2004 07:24:01 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 9 Jun 2004 07:24:01 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i597Nvi5014236 for ; Wed, 9 Jun 2004 03:23:57 -0400 Received: from zenia.home.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i597Nt009339; Wed, 9 Jun 2004 03:23:56 -0400 To: Paul Hilfinger Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA]: Turn on Ada support References: <20040608090758.C59CAF2940@nile.gnat.com> From: Jim Blandy Date: Wed, 09 Jun 2004 07:24:00 -0000 In-Reply-To: <20040608090758.C59CAF2940@nile.gnat.com> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2004-06/txt/msg00165.txt.bz2 The changes to symtab.c, symfile.c, defs.h, and gdbtypes.h are fine. I don't like the braces around the lone 'return' statements in symtab.c, though. I don't think they add much, although what's probably more germane is that it's not the typical practice elsewhere in the code. > gdb/ChangeLog: > > 2004-06-03 Paul N. Hilfinger > > Turn on initial Ada support (mainly expression evaluation). > > * Makefile.in (ada_lex_c): Define > (HFILES_NO_SRCDIR): Add ada-lang.h. > (COMMON_OBS): Add ada-lang.o, ada-typeprint.o, ada-valprint.o, > ada-tasks.o. > (YYOBJ): Add ada-exp.o. > (rule .l.c): Generalize to not mention ada. > (ada-lex.o): Remove (ada-lex.c is included by ada-exp.y). > (ada-lang.o): Add dependencies on completer.h, gdb_obstack.h, > hashtab.h. > (ada-tasks.o): Add dependency on gdb_string.h. > (ada-valprint.o): Add dependency on gdb_string.h. > > * symtab.c: Add dependency on ada-lang.h. > (symbol_natural_name): Add Ada case. > (symbol_demangled_name): Add Ada case. > (symbol_search_name): Add Ada case. > > * symfile.c (init_filename_language_table): Add extensions for > Ada. > > * defs.h (enum language): Add language_ada. > > * gdbtypes.h (TYPE_FLAG_FIXED_INSTANCE): Define.