From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-38789-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 16075 invoked by alias); 15 Apr 2005 00:20:32 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 15908 invoked from network); 15 Apr 2005 00:20:27 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sourceware.org with SMTP; 15 Apr 2005 00:20:27 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j3F0KR30018346
	for <gdb-patches@sources.redhat.com>; Thu, 14 Apr 2005 20:20:27 -0400
Received: from zenia.home.redhat.com (sebastian-int.corp.redhat.com [172.16.52.221])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j3F0KPO24486;
	Thu, 14 Apr 2005 20:20:26 -0400
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: respect -k or its absence when building sim subdirs
References: <vt2sm1ur3a0.fsf@zenia.home>
	<20050414192501.GB19262@nevyn.them.org>
From: Jim Blandy <jimb@redhat.com>
Date: Fri, 15 Apr 2005 00:20:00 -0000
In-Reply-To: <20050414192501.GB19262@nevyn.them.org>
Message-ID: <vt2aco0q4ax.fsf@zenia.home>
User-Agent: Gnus/5.090 (Gnus v5.9.0) Emacs/21.3
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2005-04/txt/msg00151.txt.bz2


Daniel Jacobowitz <drow@false.org> writes:
> On Wed, Apr 13, 2005 at 12:32:23PM -0500, Jim Blandy wrote:
> > 
> > Overkill, probably.  I just hate this kind of stuff.
> > 
> > 2005-04-13  Jim Blandy  <jimb@redhat.com>
> > 
> > 	Fix -k handling when looping over subdirectories.
> > 	* for-subdirs.sh: New script.
> > 	* Makefile.in (all clean mostlyclean distclean maintainer-clean
> > 	realclean install): Use it to loop over subdirectories.
> 
> Wow... this really is overkill, and I'm not sure that the quoting does
> what you want it to.  Can't you do this in make more straightforwardly?
> I know you can in GNU make, anyway.

Can you suggest a strategy?  Whatever you do, you have to replicate it
in each of those targets.  If it's not pretty trivial, I don't want to
write it out every time; it belongs in a "function", which, in this
world, is a script.

After I posted, I realized the quoting could be simplified to:

  clean mostlyclean:
  	@rootme=`pwd` ; export rootme ; \
! 	$(SHELL) $(srcdir)/for-subdirs.sh \
! 		"$(MAKEFLAGS)" '$(MAKE) $(FLAGS_TO_PASS) $@' $(SUBDIRS)
  

Where else were you worried about the quoting?