From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-32162-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 11543 invoked by alias); 7 Apr 2004 20:48:51 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 11531 invoked from network); 7 Apr 2004 20:48:48 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sources.redhat.com with SMTP; 7 Apr 2004 20:48:48 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i37KmjWB000776
	for <gdb-patches@sources.redhat.com>; Wed, 7 Apr 2004 16:48:45 -0400
Received: from zenia.home.redhat.com (porkchop.devel.redhat.com [172.16.58.2])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i37Kmhj21034;
	Wed, 7 Apr 2004 16:48:44 -0400
To: Brian Ford <ford@vss.fsi.com>
Cc: Mark Kettenis <kettenis@chello.nl>, gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Rename i386_xxx_reg_to_regnum
References: <8011-Fri02Apr2004094123+0300-eliz@gnu.org> <Pine dot GSO dot 4
	dot 58 dot 0404021000390 dot 21204 at thing1-200>
	<2719-Fri02Apr2004213907+0300-eliz at gnu dot org> <Pine dot GSO dot 4
	dot 58 dot 0404021648050 dot 21204 at thing1-200> <vt2ptam2gg1 dot fsf
	at zenia dot home> <Pine.GSO.4.58.0404051748340.21204@thing1-200>
	<200404062324.i36NOeA9001063@elgar.kettenis.dyndns.org>
	<Pine.GSO.4.58.0404071453310.1086@thing1-200>
From: Jim Blandy <jimb@redhat.com>
Date: Wed, 07 Apr 2004 20:48:00 -0000
In-Reply-To: <Pine.GSO.4.58.0404071453310.1086@thing1-200>
Message-ID: <vt28yh7bjnp.fsf@zenia.home>
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2004-04/txt/msg00177.txt.bz2

Brian Ford <ford@vss.fsi.com> writes:
> On Wed, 7 Apr 2004, Mark Kettenis wrote:
> 
> > Brian Ford wrote:
> >
> >> I still propose we rename the _to_regnum functions, replacing
> >> stabs and dwarf with dbx and svr4 to reduce confusion.  I'll be happy
> >> to make a patch :-).
> >
> > Please do so.
> 
> Here is the semi-pre-approved rename patch.  I decided not to make any
> style changes.
> 
> Jim, I hope you don't mind me putting words in your mouth, but I felt
> your FIXME comment needed correction as a result of this, and the previous
> change.

Just change 'jimb' to 'ford', re-use whatever text you want, and make
sure it really says what *you* want it to say; that's fine.

> 2004-04-07  Brian Ford  <ford@vss.fsi.com>
> 
>         * i386-tdep.c: Correct register numbering scheme comments throughout.
> 	(i386_stab_reg_to_regnum): Rename to i386_dbx_reg_to_regnum.
> 	(i386_dwarf_reg_to_regnum): Rename to i386_svr4_reg_to_regnum.

If you're trying to match the names in gcc/config/i386/i386.c,
shouldn't the second one be called i386_svr4_dbx_reg_to_regnum?

Otherwise, looks good to me.