From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-35878-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 1393 invoked by alias); 20 Sep 2004 16:59:24 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 1385 invoked from network); 20 Sep 2004 16:59:23 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sourceware.org with SMTP; 20 Sep 2004 16:59:23 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.11/8.12.10) with ESMTP id i8KGxI7r006124
	for <gdb-patches@sources.redhat.com>; Mon, 20 Sep 2004 12:59:18 -0400
Received: from zenia.home.redhat.com (sebastian-int.corp.redhat.com [172.16.52.221])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i8KGxHr05768;
	Mon, 20 Sep 2004 12:59:17 -0400
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa/symtab] Fix breakpoints by full path
References: <20040920001659.GA24644@nevyn.them.org>
From: Jim Blandy <jimb@redhat.com>
Date: Mon, 20 Sep 2004 16:59:00 -0000
In-Reply-To: <20040920001659.GA24644@nevyn.them.org>
Message-ID: <vt28yb4op2o.fsf@zenia.home>
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2004-09/txt/msg00316.txt.bz2


Daniel Jacobowitz <drow@false.org> writes:
> This patch fixes a bug in setting breakpoints by full path.  The problem is
> two dangling users of source_full_path_of; the right way to set
> pst->fullname now is to use psymtab_to_fullname, which takes advantage of
> pst->dirname if it was available.  source_full_path_of only considers the
> search path, which is less useful.
> 
> Without the patch, this sequence would fail:
>   cd tmp
>   gcc -o tmp tmp.c
>   cd ..
>   gdb ./tmp/tmp
>   break /path/to/tmp/tmp.c:1
> 
> But this one would succeed:
>   cd tmp
>   gcc -o tmp tmp.c
>   cd ..
>   gdb ./tmp/tmp
>   interpreter-exec mi -file-list-exec-source-files
>   break /path/to/tmp/tmp.c:1
> 
> (because -file-list-exec-source-files initialized fullname correctly).
> 
> Tested on i386-pc-linux-gnu, no regressions, fixes the new failure in
> fullname.exp.  OK?

Yep.

(Working on the Dwarf 2 ICU patch.)