From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4440 invoked by alias); 19 Nov 2002 02:39:11 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4430 invoked from network); 19 Nov 2002 02:39:09 -0000 Received: from unknown (HELO zenia.red-bean.com) (66.244.67.22) by sources.redhat.com with SMTP; 19 Nov 2002 02:39:09 -0000 Received: (from jimb@localhost) by zenia.red-bean.com (8.11.6/8.11.6) id gAJ2MdT31240; Mon, 18 Nov 2002 21:22:39 -0500 To: Klee Dienes Cc: Adam Fedor , gdb-patches@sources.redhat.com Subject: Re: [PATCH] skip_quoted (updated) References: <3FFE7016-FB19-11D6-84AF-00039396EEB8@apple.com> From: Jim Blandy Date: Mon, 18 Nov 2002 18:39:00 -0000 In-Reply-To: <3FFE7016-FB19-11D6-84AF-00039396EEB8@apple.com> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2.92 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-11/txt/msg00478.txt.bz2 Klee, your patch looks good. Adam, does it do what you need? If it does, Klee can go ahead and commit it. (With a ChangeLog entry, and a comment atop the function, of course.) Klee Dienes writes: > It must be a good name for the function, because we picked the same > one at Apple. > > You might also consider using our patch, which has the advantage of > not replicating the code between skip_quoted and skip_quoted_chars: